Desktop: Fixes #11823: Fixed "cancel" behavior when switching config screens

[rio-codes]

Issue #11823 describes behavior where clicking cancel on the dialog "This will open a new screen. Save your current changes?" switches screens anyway and retains changes. Added "else" statement to return the switchSection function on cancel before it reaches this.setState({ selectedSectionName: section.name, screenName: screenName });.

I had a typo in my Github email address so it did not recognize me as a contributor in the previous PR. Re-submitting with corrected email.

[laurent22]

I think it currently works as designed. It's supposed to be like this:

• Press OK - save changes and move to next screen
• Press Cancel - don't save the changes and move to the next screen

Maybe we need something like Yes/no/Cancel to either save, not save and move to next screen, or stay where we are

[mrjo118]

I think it currently works as designed. It's supposed to be like this:

* Press OK - save changes and move to next screen

* Press Cancel - don't save the changes and move to the next screen

Maybe we need something like Yes/no/Cancel to either save, not save and move to next screen, or stay where we are

Isn't the whole point in prompting the user to save due to switching to another screen, in order to prevent the user switching to a screen that contains auto saving configuration settings, while the user still has unsaved changes?

On mobile the equivalent dialog is different. It instead gives the option to either save changes or discard changes, rather than allowing the user to proceed with unsaved changes still pending

[rio-codes]

To me, the wording "This will open a new screen" combined with "Cancel" reads as "Don't open a new screen".