Multiple Compose Projects: RuntimeError: Backup process already running

[igolman]

Hi,

when I start backup from 2 different docker compose projects simultaneously (each project has own stackback instance), I got the following error:

Traceback (most recent call last):
  File "/restic-compose-backup/.venv/bin/rcb", line 10, in <module>
    sys.exit(main())
             ^^^^^^
  File "/restic-compose-backup/restic_compose_backup/cli.py", line 36, in main
    backup(config, containers)
  File "/restic-compose-backup/restic_compose_backup/cli.py", line 142, in backup
    raise RuntimeError("Backup process already running")
RuntimeError: Backup process already running

Since it is not running in swarm mode, should it not be scoped only to specific compose project?

[lawndoc]

You're correct, it should allow a backup process per-project. Do your projects have the same name? I'll have to read the code again to remember what it's using to distinguish between projects.

[lawndoc]

While reviewing #66 I noticed that the current release is tagging the active backup container before checking if the container is in the correct project.

stack-back/src/restic_compose_backup/containers.py

Lines 440 to 449 in 3f14a51

	# Detect running backup process container
	if container.is_backup_process_container:
	self.backup_process_container = container
	# --- Determine what containers should be evaluated
	# If not swarm mode we need to filter in compose project
	if not config.swarm_mode:
	if container.project_name != self.this_container.project_name:
	continue

I think it's very likely that this is causing the bug.

[lawndoc]

This will be fixed once the above mentioned PR is merged