Skip to content

Commit 48d05a6

Browse files
committed
Test Rails 8.0
1 parent 9aa34c5 commit 48d05a6

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

.github/workflows/ruby.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
fail-fast: false
3434
matrix:
3535
ruby-version: [ '3.4', '3.3', '3.2', 'ruby-head' ]
36-
gemfile: [ '7.2', '7.1', 'edge' ]
36+
gemfile: [ '8.0', '7.2', '7.1', 'edge' ]
3737
env:
3838
BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
3939
steps:

Rakefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ task default: %i[test rubocop:autocorrect]
3232
namespace :test do
3333
desc "Run tests for all supported Rails versions, with current Ruby version"
3434
task :all do
35-
original_directory = Dir.pwd
3635
original_gemfile = ENV["BUNDLE_GEMFILE"]
3736
gemfiles = Dir.glob("gemfiles/*.gemfile").reject { |f| File.basename(f) == "common.gemfile" }
3837
gemfiles.each do |f|
@@ -41,13 +40,14 @@ namespace :test do
4140
system("bundle exec rake test")
4241
end
4342

43+
original_directory = Dir.pwd
4444
Dir.chdir("demo")
4545
ENV.delete("BUNDLE_GEMFILE")
4646
system("bundle check") || system("bundle install")
4747
system("bundle exec rake test:all")
4848

4949
ensure
5050
original_gemfile.nil? ? ENV.delete("BUNDLE_GEMFILE") : ENV["BUNDLE_GEMFILE"] = original_gemfile
51-
Dir.chdir(original_directory)
51+
Dir.chdir(original_directory) unless original_directory.nil?
5252
end
5353
end

gemfiles/8.0.gemfile

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
gems = "#{__dir__}/common.gemfile"
2+
eval File.read(gems), binding, gems # rubocop: disable Security/Eval
3+
4+
gem "bigdecimal" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0")
5+
gem "drb" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0")
6+
gem "mutex_m" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0")
7+
gem "rails", "~> 8.0.0"
8+
gem "sprockets-rails", require: "sprockets/railtie"
9+
gem "sqlite3"

lib/bootstrap_form/inputs/check_box.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def check_box_value(name, value)
6363
# label's `for` attribute needs to match checkbox tag's id,
6464
# IE sanitized value, IE
6565
# https://github.com/rails/rails/blob/5-0-stable/actionview/lib/action_view/helpers/tags/base.rb#L123-L125
66-
"#{name}_#{value.to_s.gsub(/\s/, '_').gsub(/[^-[[:word:]]]/, '').mb_chars.downcase}"
66+
"#{name}_#{value.to_s.gsub(/\s/, '_').gsub(/[^-[[:word:]]]/, '').downcase}"
6767
end
6868

6969
def check_box_classes(name, options)

0 commit comments

Comments
 (0)