Skip to content

Commit 1e2524b

Browse files
committed
File uploads: set status code & make it fail if file upload fails for some reason
1 parent 6154fc8 commit 1e2524b

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

CHANGELOG-1.x.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
1.3.2
2+
-----
3+
4+
* File uploads: set status code & make it fail if file upload fails for some reason
5+
16
1.3.1
27
-----
38

src/Service/MediaManager.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,16 @@ private function handleFileUpload(FileBag $fileBag, string $rootDir, string $pub
8484
$response->setData([
8585
'error' => 'No file received.',
8686
]);
87+
$response->setStatusCode(400);
88+
89+
return $response;
90+
}
91+
92+
if (0 !== $file->getError()) {
93+
$response->setData([
94+
'error' => $file->getErrorMessage(),
95+
]);
96+
$response->setStatusCode(400);
8797

8898
return $response;
8999
}
@@ -92,6 +102,7 @@ private function handleFileUpload(FileBag $fileBag, string $rootDir, string $pub
92102
$response->setData([
93103
'error' => 'File too big.',
94104
]);
105+
$response->setStatusCode(400);
95106

96107
return $response;
97108
}
@@ -101,6 +112,7 @@ private function handleFileUpload(FileBag $fileBag, string $rootDir, string $pub
101112
$response->setData([
102113
'error' => 'File not supported.',
103114
]);
115+
$response->setStatusCode(400);
104116

105117
return $response;
106118
}

0 commit comments

Comments
 (0)