Skip to content

Commit be63dd1

Browse files
committed
Make use of ESPUser.objects.in_bulk()
1 parent b2ec51f commit be63dd1

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

esp/esp/customforms/DynamicForm.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -650,18 +650,15 @@ def getResponseData(self, form):
650650
elif generic_fields[ftype]['typeMap'] is not DummyField:
651651
response_data['questions'].append([qname, field['label'], ftype])
652652

653-
users = ESPUser.objects.filter(id__in=map(lambda response: response['user_id'], responses)).distinct()
654-
users_dict = {}
655-
for user in users:
656-
users_dict[user.id] = user
653+
users = ESPUser.objects.in_bulk(map(lambda response: response['user_id'], responses))
657654

658655
# Now let's set up the responses
659656
for response in responses:
660657
link_instances_cache={}
661658

662659
# Add in user if form is not anonymous
663660
if not form.anonymous:
664-
user = users_dict[response['user_id']]
661+
user = users[response['user_id']]
665662
response['user_id'] = unicode(response['user_id'])
666663
response['user_display'] = user.name()
667664
response['user_email'] = user.email

0 commit comments

Comments
 (0)