Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling checks: a way to hide false positives #1687

Closed
lenaqr opened this issue May 2, 2015 · 4 comments
Closed

Scheduling checks: a way to hide false positives #1687

lenaqr opened this issue May 2, 2015 · 4 comments

Comments

@lenaqr
Copy link

lenaqr commented May 2, 2015

This could be an alternative resolution for issues such as those discussed in #1596, #1597.

@mgersh
Copy link
Contributor

mgersh commented May 6, 2015

Implementation idea: each item has something you can click on to hide it, which happens entirely client-side. It doesn't persist across refreshes, but it probably reduces the need for refreshing, since you can click to hide something once you're done handling it instead of refreshing to clear out clutter.

@benjaminjkraft
Copy link
Contributor

I like this idea. It might not actually be that hard to persist it across reloading a single check without refreshing the page. In theory we could persist beyond that using cookies, but that might be more work. One disadvantage is that you can't share with someone else, so that the same person has to be keeping track of the same check. But that's usually what happens anyway.

@benjaminjkraft
Copy link
Contributor

Another thing: we should make sure to have an unhide button. Or, it might be easier to just put the hidden ones in very light gray, so that they are still readable, but not as obvious. Or it might be better to just not try to keep beyond reloads for this reason.

@benjaminjkraft
Copy link
Contributor

This was fixed in #1721.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants