Skip to content

Commit cc16b02

Browse files
committed
Tiling: fix edge case
1 parent 7de36fb commit cc16b02

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

ggml_extend.hpp

+17-9
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,9 @@ __STATIC_INLINE__ void ggml_merge_tensor_2d(struct ggml_tensor* input,
359359
int x,
360360
int y,
361361
int overlap_x,
362-
int overlap_y) {
362+
int overlap_y,
363+
int x_skip = 0,
364+
int y_skip = 0) {
363365
int64_t width = input->ne[0];
364366
int64_t height = input->ne[1];
365367
int64_t channels = input->ne[2];
@@ -368,16 +370,16 @@ __STATIC_INLINE__ void ggml_merge_tensor_2d(struct ggml_tensor* input,
368370
int64_t img_height = output->ne[1];
369371

370372
GGML_ASSERT(input->type == GGML_TYPE_F32 && output->type == GGML_TYPE_F32);
371-
for (int iy = 0; iy < height; iy++) {
372-
for (int ix = 0; ix < width; ix++) {
373+
for (int iy = y_skip; iy < height; iy++) {
374+
for (int ix = x_skip; ix < width; ix++) {
373375
for (int k = 0; k < channels; k++) {
374376
float new_value = ggml_tensor_get_f32(input, ix, iy, k);
375377
if (overlap_x > 0 && overlap_y > 0) { // blend colors in overlapped area
376378
float old_value = ggml_tensor_get_f32(output, x + ix, y + iy, k);
377379

378-
const float x_f_0 = (overlap_x > 0 && x > 0) ? ix / float(overlap_x) : 1;
380+
const float x_f_0 = (overlap_x > 0 && x > 0) ? (ix - x_skip) / float(overlap_x) : 1;
379381
const float x_f_1 = (overlap_x > 0 && x < (img_width - width)) ? (width - ix) / float(overlap_x) : 1;
380-
const float y_f_0 = (overlap_y > 0 && y > 0) ? iy / float(overlap_y) : 1;
382+
const float y_f_0 = (overlap_y > 0 && y > 0) ? (iy - y_skip) / float(overlap_y) : 1;
381383
const float y_f_1 = (overlap_y > 0 && y < (img_height - height)) ? (height - iy) / float(overlap_y) : 1;
382384

383385
const float x_f = std::min(std::min(x_f_0, x_f_1), 1.f);
@@ -506,10 +508,10 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
506508
input_tile_size = tile_size * scale;
507509
output_tile_size = tile_size;
508510
}
509-
int num_tiles_x = (float)(input_width - input_tile_size * tile_overlap_factor) / (float)(input_tile_size * (1 - tile_overlap_factor));
511+
int num_tiles_x = (input_width - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
510512
float tile_overlap_factor_x = (float)(input_tile_size * num_tiles_x - input_width) / (float)(input_tile_size * (num_tiles_x - 1));
511513

512-
int num_tiles_y = (float)(input_height - input_tile_size * tile_overlap_factor) / (float)(input_tile_size * (1 - tile_overlap_factor));
514+
int num_tiles_y = (input_height - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
513515
float tile_overlap_factor_y = (float)(input_tile_size * num_tiles_y - input_height) / (float)(input_tile_size * (num_tiles_y - 1));
514516

515517
LOG_DEBUG("optimal overlap : %f, %f (targeting %f)", tile_overlap_factor_x, tile_overlap_factor_y, tile_overlap_factor);
@@ -549,22 +551,28 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
549551
bool last_y = false, last_x = false;
550552
float last_time = 0.0f;
551553
for (int y = 0; y < input_height && !last_y; y += non_tile_overlap_y) {
554+
int dy = 0;
552555
if (y + input_tile_size >= input_height) {
556+
int _y = y;
553557
y = input_height - input_tile_size;
558+
dy = _y - y;
554559
last_y = true;
555560
}
556561
for (int x = 0; x < input_width && !last_x; x += non_tile_overlap_x) {
562+
int dx = 0;
557563
if (x + input_tile_size >= input_width) {
564+
int _x = x;
558565
x = input_width - input_tile_size;
566+
dx = _x - x;
559567
last_x = true;
560568
}
561569
int64_t t1 = ggml_time_ms();
562570
ggml_split_tensor_2d(input, input_tile, x, y);
563571
on_processing(input_tile, output_tile, false);
564572
if (scaled_out) {
565-
ggml_merge_tensor_2d(output_tile, output, x * scale, y * scale, tile_overlap_x * scale, tile_overlap_y * scale);
573+
ggml_merge_tensor_2d(output_tile, output, x * scale, y * scale, tile_overlap_x * scale, tile_overlap_y * scale, dx * scale, dy * scale);
566574
} else {
567-
ggml_merge_tensor_2d(output_tile, output, x / scale, y / scale, tile_overlap_x / scale, tile_overlap_y / scale);
575+
ggml_merge_tensor_2d(output_tile, output, x / scale, y / scale, tile_overlap_x / scale, tile_overlap_y / scale, dx / scale, dy / scale);
568576
}
569577
int64_t t2 = ggml_time_ms();
570578
last_time = (t2 - t1) / 1000.0f;

0 commit comments

Comments
 (0)