fix hooks in EditUser

Author: matt-fidd

Diff for: packages/desktop-client/src/components/modals/EditUser.tsx

@@ -73,50 +73,54 @@ function useGetUserDirectoryErrors() {
   return { getUserDirectoryErrors };
 }
 
-async function saveUser(
-  method: 'user-add' | 'user-update',
-  user: User,
-  setError: (error: string) => void,
-  actions: BoundActions,
-): Promise<boolean> {
+function useSaveUser() {
   const { t } = useTranslation();
-
   const { getUserDirectoryErrors } = useGetUserDirectoryErrors();
 
-  const { error, id: newId } = (await send(method, user)) || {};
-  if (!error) {
-    if (newId) {
-      user.id = newId;
-    }
-  } else {
-    setError(getUserDirectoryErrors(error));
-    if (error === 'token-expired') {
-      actions.addNotification({
-        type: 'error',
-        id: 'login-expired',
-        title: t('Login expired'),
-        sticky: true,
-        message: getUserDirectoryErrors(error),
-        button: {
-          title: t('Go to login'),
-          action: () => {
-            actions.signOut();
+  async function saveUser(
+    method: 'user-add' | 'user-update',
+    user: User,
+    setError: (error: string) => void,
+    actions: BoundActions,
+  ): Promise<boolean> {
+    const { error, id: newId } = (await send(method, user)) || {};
+    if (!error) {
+      if (newId) {
+        user.id = newId;
+      }
+    } else {
+      setError(getUserDirectoryErrors(error));
+      if (error === 'token-expired') {
+        actions.addNotification({
+          type: 'error',
+          id: 'login-expired',
+          title: t('Login expired'),
+          sticky: true,
+          message: getUserDirectoryErrors(error),
+          button: {
+            title: t('Go to login'),
+            action: () => {
+              actions.signOut();
+            },
           },
-        },
-      });
+        });
+      }
+
+      return false;
     }
 
-    return false;
+    return true;
   }
 
-  return true;
+  return { saveUser };
 }
 
 export function EditUserFinanceApp({
   defaultUser,
   onSave: originalOnSave,
 }: EditUserFinanceAppProps) {
   const { t } = useTranslation();
+  const { saveUser } = useSaveUser();
 
   return (
     <Modal name="edit-user">