feat: add innertypealias linter

Implements golangci#3490.

Author: leonklingele

.golangci.reference.yml

@@ -2047,6 +2047,7 @@ linters:
     - ifshort
     - importas
     - ineffassign
+    - innertypealias
     - interfacebloat
     - interfacer
     - ireturn
@@ -2157,6 +2158,7 @@ linters:
     - ifshort
     - importas
     - ineffassign
+    - innertypealias
     - interfacebloat
     - interfacer
     - ireturn

go.mod

@@ -44,6 +44,7 @@ require (
 	github.com/golangci/unconvert v0.0.0-20180507085042-28b1c447d1f4
 	github.com/gordonklaus/ineffassign v0.0.0-20210914165742-4cc7213b9bc8
 	github.com/gostaticanalysis/forcetypeassert v0.1.0
+	github.com/gostaticanalysis/innertypealias v0.1.1
 	github.com/gostaticanalysis/nilerr v0.1.1
 	github.com/hashicorp/go-multierror v1.1.1
 	github.com/hashicorp/go-version v1.6.0

go.sum

@@ -0,0 +1,19 @@
+package golinters
+
+import (
+	"github.com/gostaticanalysis/innertypealias"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewInnerTypeAlias() *goanalysis.Linter {
+	a := innertypealias.Analyzer
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/golinters/innertypealias.go

@@ -587,6 +587,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetUnused).
 			WithURL("https://github.com/gordonklaus/ineffassign"),
 
+		linter.NewConfig(golinters.NewInnerTypeAlias()).
+			WithSince("v1.51.0").
+			WithPresets(linter.PresetBugs).
+			WithURL("https://github.com/gostaticanalysis/innertypealias"),
+
 		linter.NewConfig(golinters.NewInterfaceBloat(interfaceBloatCfg)).
 			WithSince("v1.49.0").
 			WithPresets(linter.PresetStyle).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,26 @@
+//golangcitest:args -Einnertypealias
+package testdata
+
+type T int
+type t int
+
+type A = T // want "A is a alias for T but it is exported type"
+type B = t // OK
+
+func _() {
+	type D = T // OK
+}
+
+type E T   // OK
+type F t   // OK
+type g = t // OK
+
+type H = T // OK - it is used as an embedded field
+type _ struct{ H }
+
+type I = T // OK - it is used as an embedded field
+func _() {
+	type _ struct{ I }
+}
+
+type _ = T // OK