@@ -54,9 +54,7 @@ protected boolean runWithPackageManager(boolean silent, String... commandStrings
54
54
* @return {@code true} if installation or uninstallation succeeds with any of the package manager commands, {@code false} otherwise.
55
55
*/
56
56
protected boolean runWithPackageManager (boolean silent , List <PackageManagerCommand > pmCommands ) {
57
-
58
- logPackageManagerCommands (pmCommands );
59
-
57
+
60
58
for (PackageManagerCommand pmCommand : pmCommands ) {
61
59
PackageManager packageManager = pmCommand .packageManager ();
62
60
Path packageManagerPath = this .context .getPath ().findBinary (Path .of (packageManager .getBinaryName ()));
@@ -72,17 +70,13 @@ protected boolean runWithPackageManager(boolean silent, List<PackageManagerComma
72
70
return false ; // None of the package manager commands were successful
73
71
}
74
72
75
- private void logPackageManagerCommands (List <PackageManagerCommand > pmCommands ) {
76
- StringBuilder commandLog = new StringBuilder ("We need to run the following privileged command(s):\n " );
73
+ private void logPackageManagerCommands (PackageManagerCommand pmCommand ) {
77
74
78
- for (PackageManagerCommand pmCommand : pmCommands ) {
79
- for (String command : pmCommand .commands ()) {
80
- commandLog .append (command ).append ("\n " );
81
- }
75
+ this .context .info ("We need to run the following privileged command(s):" );
76
+ for (String command : pmCommand .commands ()) {
77
+ this .context .info (command );
82
78
}
83
- commandLog .append ("This will require root permissions!" );
84
-
85
- this .context .info (commandLog .toString ());
79
+ this .context .info ("This will require root permissions!" );
86
80
}
87
81
88
82
/**
@@ -95,6 +89,7 @@ private void logPackageManagerCommands(List<PackageManagerCommand> pmCommands) {
95
89
private boolean executePackageManagerCommand (PackageManagerCommand pmCommand , boolean silent ) {
96
90
97
91
String bashPath = this .context .findBashRequired ();
92
+ logPackageManagerCommands (pmCommand );
98
93
for (String command : pmCommand .commands ()) {
99
94
ProcessContext pc = this .context .newProcess ().errorHandling (ProcessErrorHandling .LOG_WARNING ).executable (bashPath )
100
95
.addArgs ("-c" , command );
0 commit comments