fix(controls): {Password/Text}Box clear button design (#1520)

* Fix TextBox clear button design

* Update PasswordBox.xaml

* Update TextBox.xaml

* Update PasswordBox.xaml

Author: Nuklon

src/Wpf.Ui/Controls/PasswordBox/PasswordBox.xaml

@@ -216,12 +216,17 @@
                                     Appearance="Secondary"
                                     Background="Transparent"
                                     BorderBrush="Transparent"
+                                    BorderThickness="0"
                                     Command="{Binding Path=TemplateButtonCommand, RelativeSource={RelativeSource TemplatedParent}}"
                                     CommandParameter="clear"
                                     Cursor="Arrow"
                                     Foreground="{DynamicResource TextControlButtonForeground}"
                                     Icon="{StaticResource PasswordBoxClearIcon}"
-                                    IsTabStop="False" />
+                                    IsTabStop="False"
+                                    MouseOverBackground="{DynamicResource SubtleFillColorSecondaryBrush}"
+                                    MouseOverBorderBrush="Transparent"
+                                    PressedBackground="{DynamicResource SubtleFillColorTertiaryBrush}"
+                                    PressedBorderBrush="Transparent" />
 
                                 <controls:Button
                                     x:Name="RevealButton"
@@ -237,12 +242,17 @@
                                     Appearance="Secondary"
                                     Background="Transparent"
                                     BorderBrush="Transparent"
+                                    BorderThickness="0"
                                     Command="{Binding Path=TemplateButtonCommand, RelativeSource={RelativeSource TemplatedParent}}"
                                     CommandParameter="reveal"
                                     Cursor="Arrow"
                                     Foreground="{DynamicResource TextControlButtonForeground}"
                                     Icon="{StaticResource PasswordBoxRevealIcon}"
-                                    IsTabStop="False" />
+                                    IsTabStop="False"
+                                    MouseOverBackground="{DynamicResource SubtleFillColorSecondaryBrush}"
+                                    MouseOverBorderBrush="Transparent"
+                                    PressedBackground="{DynamicResource SubtleFillColorTertiaryBrush}"
+                                    PressedBorderBrush="Transparent" />
 
                                 <ContentPresenter
                                     x:Name="ControlIconRight"
@@ -308,6 +318,7 @@
                                 <Condition Property="IsEnabled" Value="True" />
                                 <Condition Property="IsMouseOver" Value="True" />
                                 <Condition Property="IsFocused" Value="False" />
+                                <Condition SourceName="ClearButton" Property="IsFocused" Value="False" />
                             </MultiTrigger.Conditions>
                             <Setter TargetName="ContentBorder" Property="Background" Value="{DynamicResource TextControlBackgroundPointerOver}" />
                         </MultiTrigger>

src/Wpf.Ui/Controls/TextBox/TextBox.xaml

@@ -189,10 +189,15 @@
                         Appearance="Secondary"
                         Background="Transparent"
                         BorderBrush="Transparent"
+                        BorderThickness="0"
                         Command="{Binding Path=TemplateButtonCommand, RelativeSource={RelativeSource TemplatedParent}}"
                         Cursor="Arrow"
                         Foreground="{DynamicResource TextControlButtonForeground}"
-                        IsTabStop="False">
+                        IsTabStop="False"
+                        MouseOverBackground="{DynamicResource SubtleFillColorSecondaryBrush}"
+                        MouseOverBorderBrush="Transparent"
+                        PressedBackground="{DynamicResource SubtleFillColorTertiaryBrush}"
+                        PressedBorderBrush="Transparent">
                         <controls:Button.Icon>
                             <controls:SymbolIcon FontSize="{TemplateBinding FontSize}" Symbol="Dismiss24" />
                         </controls:Button.Icon>
@@ -253,6 +258,7 @@
                     <Condition Property="IsEnabled" Value="True" />
                     <Condition Property="IsMouseOver" Value="True" />
                     <Condition Property="IsFocused" Value="False" />
+                    <Condition SourceName="ClearButton" Property="IsFocused" Value="False" />
                 </MultiTrigger.Conditions>
                 <Setter TargetName="ContentBorder" Property="Background" Value="{DynamicResource TextControlBackgroundPointerOver}" />
             </MultiTrigger>