Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change or update joda-time java project for maven integration section (6.2.2) #390

Open
tjvkroll opened this issue Sep 7, 2023 · 0 comments

Comments

@tjvkroll
Copy link
Contributor

tjvkroll commented Sep 7, 2023

Problem:
Currently the java project "joda-time" will not build out of the box. After cloning down the repo that is linked in the bootcamp if you try to run maven verify, it won't compile due the java version dependency. After changing the pom to fix this it fails tests that are calling deprecated functions. As part of the section's exercises, joda-time is being added as a dependency to the spring-petclinic project to practice Maven Integration. Since the focus of this section is more on integrating different artifacts in a projects release, it doesn't add value to have to fix the joda-time project. With this in mind we should make a decision on what to do with the joda-time project.

There are two proposed options for this change:

  1. Find a new java project that compiles and deploys without errors to be added as the dependency for Spring pet clinic as part of exercises 1&2.

  2. Create a liatrio fork of the joda-time project, update the link in the section to point to liatio's fork and make the necessary changes so the it'll at least build out of the box.
    Changes needed to build:
    a) change lines 1074-1076 of joda-time's pom file to use 1.8 and not 1.5. (updates version so that the project compiles)
    b) Comment out or just remove a specific test due to a deprecated function call that causes it to fail
    - Test can be found at /joda-time/src/test/java/org/joda/time/testDateTimeZone.java
    - specific test to be commented/removed is "testZoneInfoProviderResourceLoading" on lines 586-615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant