2D rendering memory leak

[slouken]

gpu.mp4

vulkan.mp4

opengl.mp4

When I used 2D hardware accelerated renderer and quickly resized the window, I find that directX and opengl didn't cause memory leak but vulkan and gpu. And using vulkan or gpu all caused inside view resizing following resizing the window.

Originally posted by @KevinLenzz in #12737

[slouken]

@KevinLenzz, can you provide a simple reproduceable example of this so we can take a look?

[SimonMaracine]

It happens for me too with Vulkan. OpenGL doesn't seem to leak anything.

[SimonMaracine]

This MCVE also leaks with Vulkan:

#include <SDL3/SDL.h>

int main() {
    SDL_Window* window {};
    SDL_Renderer* renderer {};
    bool running {true};

    SDL_InitSubSystem(SDL_INIT_VIDEO);
    SDL_CreateWindowAndRenderer("Alfred", 1280, 720, SDL_WINDOW_RESIZABLE, &window, &renderer);
    SDL_SetRenderVSync(renderer, 0);

    while (running) {
        SDL_Event event;

        while (SDL_PollEvent(&event)) {
            switch (event.type) {
                case SDL_EVENT_QUIT:
                    running = false;
                    break;
            }
        }

        SDL_RenderClear(renderer);
        SDL_RenderPresent(renderer);
    }

    SDL_DestroyRenderer(renderer);
    SDL_DestroyWindow(window);
    SDL_QuitSubSystem(SDL_INIT_VIDEO);
    SDL_Quit();
}

[slouken]

What platform are you seeing issues on?

I'm running this test on Windows 11 and it's holding steady at 55.8 MB:

#include <SDL3/SDL.h>
#include <SDL3/SDL_main.h>

int main(int argc, char *argv[])
{
    SDL_Window *window;
    SDL_Renderer *renderer;
    bool running = true;
    Uint8 color = 0;

    SDL_SetHint(SDL_HINT_RENDER_DRIVER, "vulkan");
    SDL_InitSubSystem(SDL_INIT_VIDEO);
    SDL_CreateWindowAndRenderer("Alfred", 1280, 720, SDL_WINDOW_RESIZABLE, &window, &renderer);
    SDL_SetRenderVSync(renderer, 0);

    while (running) {
        SDL_Event event;

        while (SDL_PollEvent(&event)) {
            switch (event.type) {
            case SDL_EVENT_QUIT:
                running = false;
                break;
            }
        }

        SDL_SetRenderDrawColor(renderer, 0, (color++)/8, 0, SDL_ALPHA_OPAQUE);
        SDL_RenderClear(renderer);
        SDL_RenderPresent(renderer);
    }

    SDL_DestroyRenderer(renderer);
    SDL_DestroyWindow(window);
    SDL_QuitSubSystem(SDL_INIT_VIDEO);
    SDL_Quit();
    return 0;
}

[SimonMaracine]

What platform are you seeing issues on?

Linux and Wayland. Do you want me to test other rendering API besides Vulkan and OpenGL and to send a short video?

[slouken]

What platform are you seeing issues on?

Linux and Wayland. Do you want me to test other rendering API besides Vulkan and OpenGL and to send a short video?

No, that's fine. What video card and driver versions do you have?

[SimonMaracine]

What video card and driver versions do you have?

Card: NVIDIA GeForce GTX 1050 Ti
Version: 580.119.02

[KevinLenzz]

@KevinLenzz, can you provide a simple reproduceable example of this so we can take a look?

#include <SDL3/SDL.h>

int main() {
    SDL_Window* window {};
    SDL_Renderer* renderer {};
    bool running {true};

    SDL_InitSubSystem(SDL_INIT_VIDEO);

    window = SDL_CreateWindow("Alfred", 1280, 720, SDL_WINDOW_RESIZABLE | SDL_WINDOW_VULKAN);
    if (!window) {
        SDL_Log("Failed to create window: %s", SDL_GetError());
        return -1;
    }

    renderer = SDL_CreateRenderer(window, "vulkan");
    if (!renderer) {
        SDL_Log("Failed to create renderer: %s", SDL_GetError());
        SDL_DestroyWindow(window);
        SDL_QuitSubSystem(SDL_INIT_VIDEO);
        return -1;
    }

    SDL_SetRenderVSync(renderer, 0);

    while (running) {
        SDL_Event event;

        while (SDL_PollEvent(&event)) {
            switch (event.type) {
                case SDL_EVENT_QUIT:
                    running = false;
                    break;
            }
        }

        SDL_RenderClear(renderer);

        SDL_RenderPresent(renderer);
    }

    SDL_DestroyRenderer(renderer);
    SDL_DestroyWindow(window);
    SDL_QuitSubSystem(SDL_INIT_VIDEO);
    SDL_Quit();

    return 0;
}

This is a minimized memleak code example.
Also it is the mini vulkan 2D render accelerating usage, it just can cause leak.
Windows 11 25H2
AMD Ryzen 7 7840H with Radeon 780M Graphics

[slouken]

I can reproduce this, thanks!

It doesn't happen with the GPU driver using Vulkan, so it looks like it's a bug specific to the Vulkan 2D renderer in SDL.

[slouken]

I'm walking through the swapchain recreation in VULKAN_CreateSwapChain() and not seeing anything that isn't freed from the previous swap chain. Have you tracked down what is being leaked?

@danginsburg, do you have any suggestions on tracking this leak down?