Merge pull request #2 from lichess-org/fix-warnings/0

Fix more compilation warnings

Author: lenguyenthanh

build.sbt

@@ -38,15 +38,15 @@ lazy val PlayProject = Project("Play", file("core/play"))
       scalaVersion.value
     ) ++ scalacheckDependencies ++ cookieEncodingDependencies :+
       jimfs % Test,
-    (sourceGenerators in Compile) += Def
+    (Compile / sourceGenerators) += Def
       .task(
         PlayVersion(
           version.value,
           scalaVersion.value,
           sbtVersion.value,
           Dependencies.akkaVersion,
           Dependencies.akkaHttpVersion,
-          (sourceManaged in Compile).value
+          (Compile / sourceManaged).value
         )
       )
       .taskValue
@@ -67,9 +67,8 @@ lazy val PlayLogback = Project("Play-Logback", file("core/play-logback"))
   .settings(playCommonSettings)
   .settings(
     libraryDependencies += logback,
-    parallelExecution in Test := false,
-    // quieten deprecation warnings in tests
-    scalacOptions in Test := (scalacOptions in Test).value.diff(Seq("-deprecation"))
+    Test / parallelExecution := false,
+    Test / scalacOptions := (Test / scalacOptions).value.diff(Seq("-deprecation"))
   )
   .dependsOn(PlayProject)
 
@@ -78,8 +77,7 @@ lazy val PlayConfiguration = Project("Play-Configuration", file("core/play-confi
   .settings(
     libraryDependencies ++= Seq(typesafeConfig, slf4jApi) ++ specs2Deps.map(_ % Test),
     (Test / parallelExecution) := false,
-    // quieten deprecation warnings in tests
-    (scalacOptions in Test) := (scalacOptions in Test).value.diff(Seq("-deprecation"))
+    (Test / scalacOptions) := (Test / scalacOptions).value.diff(Seq("-deprecation"))
   )
   .dependsOn(PlayExceptionsProject)
 

dev-mode/routes-compiler/src/main/scala/play/routes/compiler/RoutesCompiler.scala

@@ -9,7 +9,7 @@ import java.nio.charset.Charset
 import java.nio.charset.MalformedInputException
 import java.nio.file.Files
 
-import scala.collection.JavaConverters.*
+import scala.jdk.CollectionConverters.*
 
 import scala.io.Codec
 

dev-mode/routes-compiler/src/main/scala/play/routes/compiler/RoutesFileParser.scala

@@ -45,7 +45,9 @@ object RoutesFileParser:
         validate(routesFile, parsed.collect { case r: Route => r }) match
           case Nil => Right(parsed)
           case errors => Left(errors)
-      case parser.NoSuccess(message, in) =>
+      case parser.Error(message, in) =>
+        Left(Seq(RoutesCompilationError(routesFile, message, Some(in.pos.line), Some(in.pos.column))))
+      case parser.Failure(message, in) =>
         Left(Seq(RoutesCompilationError(routesFile, message, Some(in.pos.line), Some(in.pos.column))))
 
   /**

dev-mode/routes-compiler/src/main/twirl/play/routes/compiler/static/reverseRouter.scala.twirl

@@ -10,11 +10,11 @@ import play.core.routing.{dynamicString}
 @for(i <- imports) {
 import @if(!i.startsWith("_root_.")){_root_.}@i}
 
-@markLines(routes: _*)
+@markLines(routes*)
 package routes @ob
 
 @for((controller, routes) <- groupRoutesByController(routes)) {
-  @markLines(routes: _*)
+  @markLines(routes*)
   object @(controller.replace(".", "_")) @ob
 
   @for(((method, _), routes) <- groupRoutesByMethod(routes)) {@routes match {
@@ -26,7 +26,7 @@ package routes @ob
     @cb
   }
   case _ => {
-    @markLines(routes: _*)
+    @markLines(routes*)
     def @(method)@(reverseSignature(routes)): Call = @ob
     @defining(reverseParameters(routes)) { params =>
       (@reverseMatchParameters(params, true)) match @ob