Skip to content

Commit 7251bc5

Browse files
Merge pull request #31 from lichess-org/fix-compilation-warnings
Fix compilation warnings
2 parents 03b475e + 4b8ebfb commit 7251bc5

2 files changed

Lines changed: 9 additions & 15 deletions

File tree

core/play/src/main/scala/play/core/parsers/Multipart.scala

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -141,19 +141,11 @@ object Multipart:
141141
Right(
142142
MultipartFormData(
143143
parts
144-
.collect { case dp: DataPart =>
145-
dp
146-
}
144+
.collect { case dp: DataPart => dp }
147145
.groupBy(_.key)
148-
.map { case (key, partValues) =>
149-
key -> partValues.map(_.value)
150-
},
151-
parts.collect { case fp: FilePart[A] =>
152-
fp
153-
},
154-
parts.collect { case bad: BadPart =>
155-
bad
156-
}
146+
.map { case (key, partValues) => key -> partValues.map(_.value) },
147+
parts.collect { case fp: FilePart[?] => fp.asInstanceOf[FilePart[A]] },
148+
parts.collect { case bad: BadPart => bad }
157149
)
158150
)
159151
)

dev-mode/routes-compiler/src/main/scala/play/routes/compiler/RoutesFileParser.scala

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,8 @@ private[routes] class RoutesFileParser extends JavaTokenParsers:
127127
override def skipWhitespace = false
128128
override val whiteSpace = """[ \t]+""".r
129129

130+
case class ModifiersWithComment(modifiers: List[Modifier], comment: Option[Comment])
131+
130132
def EOF: util.matching.Regex = "\\z".r
131133

132134
def namedError[A](p: Parser[A], msg: String): Parser[A] = Parser[A] { i =>
@@ -169,8 +171,8 @@ private[routes] class RoutesFileParser extends JavaTokenParsers:
169171
Modifier.apply
170172
))
171173

172-
def modifiersWithComment: Parser[(List[Modifier], Option[Comment])] = modifiers ~ opt(comment) ^^ {
173-
case m ~ c => (m, c)
174+
def modifiersWithComment: Parser[ModifiersWithComment] = modifiers ~ opt(comment) ^^ { case m ~ c =>
175+
ModifiersWithComment(m, c)
174176
}
175177

176178
def newLine: Parser[String] = namedError(("\r" ?) ~> "\n", "End of line expected")
@@ -325,7 +327,7 @@ private[routes] class RoutesFileParser extends JavaTokenParsers:
325327
case (s, c @ ()) => (None, Nil, Nil) :: s
326328
case ((r, comments, modifiers) :: others, c: Comment) =>
327329
(r, c :: comments, modifiers) :: others
328-
case ((r, comments, modifiers) :: others, (ms: List[Modifier], c: Option[Comment])) =>
330+
case ((r, comments, modifiers) :: others, ModifiersWithComment(ms, c)) =>
329331
(r, c.toList ::: comments, ms ::: modifiers) :: others
330332
case (s, _) => s
331333
}

0 commit comments

Comments
 (0)