Missing fix for Python bindings

romainthomas · romainthomas · commit 62435492f0ee · 2025-03-29T11:20:18.000+01:00
diff --git a/api/python/CMakeLists.txt b/api/python/CMakeLists.txt
@@ -69,6 +69,10 @@ set_target_properties(pyLIEF PROPERTIES
   OUTPUT_NAME                  "_lief"
 )
 
+if (MSVC AND NOT CLANG_CL AND NOT LIEF_EXTERNAL_SPDLOG)
+  target_compile_definitions(LIB_LIEF PRIVATE FMT_UNICODE=0)
+endif()
+
 target_link_libraries(pyLIEF PUBLIC ${LIEF_TARGET} lief_spdlog)
 
 if(APPLE)

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,10 @@ set_target_properties(pyLIEF PROPERTIES`
`69`	`69`	`OUTPUT_NAME "_lief"`
`70`	`70`	`)`
`71`	`71`
	`72`	`+if (MSVC AND NOT CLANG_CL AND NOT LIEF_EXTERNAL_SPDLOG)`
	`73`	`+ target_compile_definitions(LIB_LIEF PRIVATE FMT_UNICODE=0)`
	`74`	`+endif()`
	`75`	`+`
`72`	`76`	`target_link_libraries(pyLIEF PUBLIC ${LIEF_TARGET} lief_spdlog)`
`73`	`77`
`74`	`78`	`if(APPLE)`