fix: handling workflow step call exceptions #2376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
changed the title
johanandren
approved these changes
Nov 11, 2025
Contributor
johanandren
left a comment
johanandren
left a comment
There was a problem hiding this comment.
LGTM, test coverage to messy to add?
| .asInstanceOf[JFunc[Any, CompletionStage[Any]]] | ||
| .apply(decodedInput) | ||
| .asScala | ||
| }.flatten |
Contributor
There was a problem hiding this comment.
I guess wrapping is to make sure it always fails the future and doesn't throw on the calling thread?
aludwiko
deleted the
4470-kalix-workflow-asynccall-should-catch-exceptions-outside-the-future-composition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References https://github.com/lightbend/akka-runtime/issues/4470
tested manually with a custom workflow implementation