Dimension filters #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I formatted the files I changed with Black --line-length 80, please let me know if you prefer other settings |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for filtering query results by dimension values in the Python SDK. Key changes include new tests for dimension filters, updates to the Query and Model classes to accept filters, and the introduction of a new filter module.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_acceptance.py | Added tests for filtering queries by dimension values |
| lightdash/query.py | Updated Query to accept and process filters in query payload |
| lightdash/models.py | Updated query method to pass filters to Query |
| lightdash/filter.py | Introduced DimensionFilter and CompositeFilter for query filtering support |
Comments suppressed due to low confidence (1)
lightdash/filter.py:99
- [nitpick] The variable name 'filter' shadows a built-in function. It is recommended to rename it (e.g., to 'flt') to avoid potential confusion.
for filter in self.filters:
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addressing #6, allowing to filter by dimension values