Skip to content

Commit 6d1f74c

Browse files
committed
Skip the strip step on Windows
This partially reverts 5a78aa8
1 parent 6ea3392 commit 6d1f74c

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

genbindings.sh

+8-3
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@ IS_WIN=false
3737
IS_APPLE_CLANG=false
3838
[ "$($CC --version | grep "Apple clang version")" != "" ] && IS_APPLE_CLANG=true
3939

40+
STRIP=llvm-strip
41+
[ "$IS_APPLE_CLANG" = "true" ] && STRIP=echo
42+
4043
case "$TARGET_STRING" in
4144
"x86_64-pc-linux"*)
4245
LDK_TARGET_SUFFIX="_Linux-amd64"
@@ -66,6 +69,8 @@ case "$TARGET_STRING" in
6669
CS_PLATFORM_NAME="win-x64"
6770
LDK_JAR_TARGET=true
6871
IS_WIN=true
72+
# llvm-strip currently corrupts DLLs - https://github.com/llvm/llvm-project/issues/63081
73+
STRIP=echo
6974
;;
7075
*)
7176
LDK_TARGET_SUFFIX="_${TARGET_STRING}"
@@ -171,7 +176,7 @@ if [ "$2" = "c_sharp" ]; then
171176
# so we have to build with faketime.
172177
faketime -f "2021-01-01 00:00:00" $COMPILE -o bindings.o -c -O3 -I"$1"/lightning-c-bindings/include/ c_sharp/bindings.c
173178
faketime -f "2021-01-01 00:00:00" $COMPILE $LINK -o libldkcsharp_release$LDK_TARGET_SUFFIX.so -O3 bindings.o $LDK_LIB -lm
174-
[ "$IS_APPLE_CLANG" != "true" ] && llvm-strip -R .llvmbc -R .llvmcmd libldkcsharp_release$LDK_TARGET_SUFFIX.so
179+
$STRIP -R .llvmbc -R .llvmcmd libldkcsharp_release$LDK_TARGET_SUFFIX.so
175180

176181
if [ "$LDK_JAR_TARGET" = "true" ]; then
177182
# Copy resulting native binary for inclusion in release nuget zip
@@ -225,7 +230,7 @@ elif [ "$2" = "python" ]; then
225230
else
226231
$COMPILE -o bindings.o -c -flto -O3 -I"$1"/lightning-c-bindings/include/ $2 c_sharp/bindings.c
227232
$COMPILE $LINK -o liblightningpython_release$LDK_TARGET_SUFFIX.so -Wl,--version-script=python/libcode.version -flto -O3 -Wl,--lto-O3 -Wl,-O3 -I"$1"/lightning-c-bindings/include/ $2 bindings.o "$1"/lightning-c-bindings/target/$LDK_TARGET/release/libldk.a -lm
228-
[ "$IS_APPLE_CLANG" != "true" ] && llvm-strip -R .llvmbc -R .llvmcmd liblightningpython_release$LDK_TARGET_SUFFIX.so
233+
$STRIP -R .llvmbc -R .llvmcmd liblightningpython_release$LDK_TARGET_SUFFIX.so
229234
fi
230235
elif [ "$2" = "wasm" ]; then
231236
echo "Creating TS bindings..."
@@ -341,7 +346,7 @@ else
341346

342347
$COMPILE -o bindings.o -c -O3 -I"$1"/lightning-c-bindings/include/ $2 src/main/jni/bindings.c
343348
$COMPILE $LINK -o liblightningjni_release$LDK_TARGET_SUFFIX.so -O3 $2 bindings.o $LDK_LIB -lm
344-
[ "$IS_APPLE_CLANG" != "true" ] && llvm-strip -R .llvmbc -R .llvmcmd liblightningjni_release$LDK_TARGET_SUFFIX.so
349+
$STRIP -R .llvmbc -R .llvmcmd liblightningjni_release$LDK_TARGET_SUFFIX.so
345350

346351
if [ "$IS_MAC" = "false" -a "$4" = "false" ]; then
347352
GLIBC_SYMBS="$(objdump -T liblightningjni_release$LDK_TARGET_SUFFIX.so | grep GLIBC_ | grep -v "GLIBC_2\.\(2\|3\)\(\.\|)\)" | grep -v "GLIBC_2.\(3\.4\|14\|17\|18\|25\|28\|29\|32\|33\|34\|\))" || echo)"

0 commit comments

Comments
 (0)