Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept_forwards_to_priv_channels is always false #499

Open
TheBlueMatt opened this issue Mar 21, 2025 · 2 comments · May be fixed by #503
Open

accept_forwards_to_priv_channels is always false #499

TheBlueMatt opened this issue Mar 21, 2025 · 2 comments · May be fixed by #503

Comments

@TheBlueMatt
Copy link

default_user_config sets user_config.accept_forwards_to_priv_channels = false; if !may_announce_channel(config) but it also defaults to false, so its always false.
@TheBlueMatt TheBlueMatt mentioned this issue Mar 21, 2025
Open
@tnull
Copy link
Collaborator

tnull commented Mar 21, 2025

Hmm, good catch. But, I'm kind of confused why we didn't hit this before in testing. I guess accept_forwards_to_priv_channels does not apply for intercepted payments that we manually forward.

@tnull tnull linked a pull request Mar 21, 2025 that will close this issue
Open
@tnull
Copy link
Collaborator

tnull commented Mar 21, 2025

Now opened #503

@TheBlueMatt TheBlueMatt mentioned this issue Mar 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow forwarding to unannounced channels if LSP service is enabled tnull/ldk-node
2 participants
@tnull @TheBlueMatt