Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose proper Invoice / Offer types in bindings #504

Open
tnull opened this issue Mar 21, 2025 · 1 comment
Open

Expose proper Invoice / Offer types in bindings #504

tnull opened this issue Mar 21, 2025 · 1 comment

Comments

@tnull
Copy link
Collaborator

tnull commented Mar 21, 2025

Previously, we'd expose Bolt11Invoice/Offer/Refunds as strings in bindings that get translated at time of use via UniffiCustomTypeConverters. This has a number of drawbacks, maybe most notably that these types don't allow the user to validate any fields before paying them.

We should expose 'propertypes for these (i.e., likely we'd need to create newtype wrappers for at least some of them based on theuniffi` feature flag) that allow retrieving all the important fields (amount, description, payer_note, etc).

@alexanderwiederin
Copy link
Contributor

Happy to look into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants