Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup initial integration tests with LND #505

Closed
tnull opened this issue Mar 21, 2025 · 2 comments · Fixed by #509
Closed

Setup initial integration tests with LND #505

tnull opened this issue Mar 21, 2025 · 2 comments · Fixed by #509
Labels
good first issue Good for newcomers

Comments

@tnull
Copy link
Collaborator

tnull commented Mar 21, 2025 •
edited
Loading

We already have rudimentary integration tests with CLN that run in CI. It would be great to also run similar integration tests for LND:
a) Run a dockerized LND node in CI
b) Use a Rust library to interact with LND's gRPC interface. The tonic_lnd crate is the obvious contender here, although last I checked it was only compatible with an older LND version, so we'll have to check whether it would still work for current/future releases for our purposes
c) As a first step, replicate the CLN integration test. Essentially: open channel, send payment, check that it was received as expected. Have LND send a payment, check we received it as expected.
@tnull tnull added the good first issue Good for newcomers label Mar 21, 2025
@elnosh
Copy link
Contributor

elnosh commented Mar 21, 2025

can I pick this up

moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
c017d1a 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
eca36a5 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
d1bc815 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
24bd243 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
0839bc4 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
f3f4ea9 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
a36baaf 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
a08e364 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
c0e4b0b 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
b785427 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
@moisesPompilio moisesPompilio mentioned this issue Mar 26, 2025
Merged
@tnull
Copy link
Collaborator Author

tnull commented Mar 26, 2025

can I pick this up

Ah, sorry, but @moisesPompilio already did in #509.

moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
cdccf68 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
7c400d9 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
9b21153 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
f9c1769 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 26, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
2abfdcf 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 27, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
626097c 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 27, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
dd4bb77 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 27, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
ee61986 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 27, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
6f1017c 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 28, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
a56230f 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 28, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
f8b3d2d 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 28, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
43bda7a 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 28, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
de9086f 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 28, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
4e97c04 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 28, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
86d096a 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 28, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
08734ff 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 28, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
51fe0a3 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 28, 2025
@moisesPompilio
feat: implement LND integration tests with lnd_grpc_rust
8d81a4c 
Adds tests to:
- Open a payment channel with LND.
- Request and pay an invoice, verifying receipt.
- Generate an invoice for LND to pay, verifying receipt.
Uses lnd_grpc_rust for gRPC communication.

Closes lightningdevkit#505
moisesPompilio added a commit to moisesPompilio/ldk-node that referenced this issue Mar 28, 2025
@moisesPompilio
ci: add GitHub Actions workflow for LND integration tests
7d592bb 
Configures CI to run LND tests using the Docker Compose environment.

Closes lightningdevkit#505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add LND Integration Tests in CI moisesPompilio/ldk-node
2 participants
@tnull @elnosh