Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate gossip storage from MessageSendEventsProvider #80

Open
arik-so opened this issue May 15, 2024 · 0 comments
Open

Investigate gossip storage from MessageSendEventsProvider #80

arik-so opened this issue May 15, 2024 · 0 comments

Comments

@arik-so
Copy link
Contributor

arik-so commented May 15, 2024

In downloader.rs, we trigger the storage of gossip messages from get_and_clear_pending_msg_events, but we also trigger the same storage from RoutingMessageHandler.

We should ask our past selves why we did that, and either document that requirement better, or get rid of the dupes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant