Lint fix

Author: optout21

lightning-invoice/src/de.rs

@@ -94,7 +94,7 @@ impl FromBase32 for Bolt11InvoiceFeatures {
 		let mut output = Vec::<u8>::new();
 
 		// Iterate over input in reverse
-		for (_, curr_in) in field_data.into_iter().rev().enumerate() {
+		for curr_in in field_data.iter().rev() {
 			let curr_in_as_u8 = curr_in.to_u8();
 			if carry_bits >= 3 {
 				// we have a new full byte -- 3, 4 or 5 carry bits, plus 5 new ones
@@ -105,7 +105,7 @@ impl FromBase32 for Bolt11InvoiceFeatures {
 				carry_bits -= 3; // added 5, removed 8
 			} else {
 				// only 0, 1, or 2 carry bits,  plus 5 new ones
-				carry = carry + (curr_in_as_u8 << carry_bits);
+				carry += curr_in_as_u8 << carry_bits;
 				carry_bits += 5;
 			}
 		}

lightning-invoice/src/ser.rs

@@ -86,7 +86,7 @@ impl Base32Iterable for Bolt11InvoiceFeatures {
 	/// with the leading 0's skipped.
 	fn fe_iter<'s>(&'s self) -> Box<dyn Iterator<Item = Fe32> + 's> {
 		// Fe32 conversion cannot be used, because this packs from right, right-to-left
-		let mut input_iter = self.le_flags().into_iter();
+		let mut input_iter = self.le_flags().iter();
 		// Carry bits, 0..7 bits
 		let mut carry = 0u8;
 		let mut carry_bits = 0;
@@ -96,7 +96,7 @@ impl Base32Iterable for Bolt11InvoiceFeatures {
 			let next_out8 = if carry_bits >= 5 {
 				// We have enough carry bits for an output, no need to read the input
 				let next_out8 = carry;
-				carry = carry >> 5;
+				carry >>= 5;
 				carry_bits -= 5;
 				next_out8
 			} else {
@@ -122,7 +122,7 @@ impl Base32Iterable for Bolt11InvoiceFeatures {
 			output.push(Fe32::try_from(next_out8 & 31u8).expect("<32"))
 		}
 		// Take result in reverse order, and skip leading 0s
-		return Box::new(output.into_iter().rev().skip_while(|e| *e == Fe32::Q));
+		Box::new(output.into_iter().rev().skip_while(|e| *e == Fe32::Q))
 	}
 }
 
@@ -221,9 +221,8 @@ impl Display for SiPrefix {
 fn encode_int_be_base32(int: u64) -> Vec<Fe32> {
 	let base = 32u64;
 
-	const LEN: usize = (64 + 4) / 5;
-	debug_assert!(LEN == 13); // for validating LEN (mutants)
-	let mut out_vec = Vec::<Fe32>::with_capacity(LEN);
+	// (64 + 4) / 5 == 13
+	let mut out_vec = Vec::<Fe32>::with_capacity(13);
 	let mut rem_int = int;
 	while rem_int != 0 {
 		out_vec.push(Fe32::try_from((rem_int % base) as u8).expect("always <32"));

lightning/src/offers/parse.rs

@@ -71,7 +71,7 @@ mod sealed {
 			encode_to_fmt::<NoChecksum, _>(f, Hrp::parse(Self::BECH32_HRP).unwrap(), self.as_ref())
 				.map_err(|e| match e {
 					EncodeError::Fmt(e) => e,
-					_ => fmt::Error::default(),
+					_ => fmt::Error {},
 				})
 		}
 	}