Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give HTLCHandlingFailed a reason of some kind #3541

Open
TheBlueMatt opened this issue Jan 15, 2025 · 2 comments · May be fixed by #3601
Open

Give HTLCHandlingFailed a reason of some kind #3541

TheBlueMatt opened this issue Jan 15, 2025 · 2 comments · May be fixed by #3601
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment

Comments

@TheBlueMatt
Copy link
Collaborator

With #2933 we're gonna expand substantially the cases where we generate an HTLCHandlingFailed. It would be nice to give the event a reason code for users to look at now.

@TheBlueMatt TheBlueMatt added the Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment label Jan 15, 2025
@carlaKC carlaKC linked a pull request Feb 13, 2025 that will close this issue
@joostjager
Copy link
Contributor

joostjager commented Mar 17, 2025

If I understand it correctly, HTLCHandlingFailed was already generated (without reason code), but just not in all failure cases. What is the background of adding the reason code? Is it nice to have as you say, or does it also unlock use cases that weren't possible previously because HTLCHandlingFailed wasn't generated always?

@carlaKC
Copy link
Contributor

carlaKC commented Mar 17, 2025

Discussed on LDK dev meeting today, motivation is to add more programatic observability to LDK - useful for tracking HTLC stats more granularly, for example. Generally just nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants