-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BackgroundProcessor::start_without_om
#3612
Comments
Hi @TheBlueMatt, I'll like to work on this issue. Can it be assigned to me please? |
Go for it! |
Thank you @TheBlueMatt. On it! |
It might be a bit late to mention this, but given that we'll need to introduce similar variants for Otherwise the API might get a bit messy if we add constructors for all combinations of parameters? |
Good call @tnull. IMO I believe the builder pattern is the most flexible solution that can easily accommodate future additions. I'll open a PR for this mid next week. |
BackgroundProcessor::start
takes anOption
for theOnionMessenger
which is quite annoying as it requires a concrete type for theOnionMessenger
even when passingNone
. We should add a new constructor to make this easier for users.The text was updated successfully, but these errors were encountered: