Allow setting a payer_note on pay_for_offer_from_human_readable_name
#3808
Conversation
|
👋 Thanks for assigning @carlaKC as a reviewer! |
pay_for_offer and pay_for_offer_from_human_readable_name take RouteParametersConfig and not max_total_routing_fee_msat.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3808 +/- ##
==========================================
+ Coverage 89.73% 89.78% +0.04%
==========================================
Files 159 159
Lines 128910 128993 +83
Branches 128910 128993 +83
==========================================
+ Hits 115682 115810 +128
+ Misses 10535 10485 -50
- Partials 2693 2698 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.. as we'd otherwise never catch any bugs particular to the `dnssec` feature.
.. and link all instances for consistency.
There was a problem hiding this comment.
LGTM
I took the liberty of pushing three additional commits to this PR branch that cleanup preexisting doc breakage/nits under the dnssec feature, and ensure we cargo test/check/doc lightning with dnssec in CI to make sure we catch such things going forward. (cc @TheBlueMatt)
| @@ -405,7 +406,86 @@ mod test { | |||
| let params = RouteParametersConfig::default(); | |||
| nodes[0] | |||
| .node | |||
| .pay_for_offer_from_human_readable_name(name, amt, payment_id, retry, params, resolvers) | |||
| .pay_for_offer_from_human_readable_name( | |||
There was a problem hiding this comment.
Should be okay for now because kinda pre-existing, but going forward we'll probably want to DRY up that test code instead of copy/pasting the same flow.
|
noted, thanks for the review! @tnull |
|
🔔 1st Reminder Hey @TheBlueMatt @carlaKC! This PR has been waiting for your review. |
Closes #3780
Allows setting a
payer_noteonpay_for_offer_from_human_readable_nameand added a similarly named field to theAwaitingOffer. When paying the offer, it will get thepayer_notefromparams_for_payment_awaiting_offer.