Skip to content

Tag new releases for kvdb, queue, and sqldb submodules to drop root replace directives #10854

@ziggie1984

Description

@ziggie1984

The root go.mod carries three replace directives that point submodules at the in-tree copy:

// TODO(gijs): remove once new queue package is released.
replace github.com/lightningnetwork/lnd/queue => ./queue

// TODO(elle): remove once the gossip V2 sqldb changes have been made.
replace github.com/lightningnetwork/lnd/sqldb => ./sqldb

// TODO: remove once kvdb with pgx/v5 is released.
replace github.com/lightningnetwork/lnd/kvdb => ./kvdb

The awaited changes already exist on master but no tag has been cut that contains them:

  • queue — last tag queue/v1.1.1. Master contains queue: add BackpressureQueue[T] with Random Early Drop (ea8a665), which is the "new queue package" referenced in the TODO. Needs queue/v1.2.0.
  • kvdb — last tag kvdb/v1.4.16. Master contains kvdb: bump pgx/v4/stdlib to pgx/v5/stdlib (848af80) — the pgx/v5 change called out in the TODO. Needs kvdb/v1.5.0.
  • sqldb — last tag sqldb/v1.0.12 (root go.mod still pins v1.0.11). Master contains the full sqldb/v2 work and the gossip-V2-related schema/queries. Needs the next sqldb release once the v2/gossip work is ready to ship.

Action items

  • Cut kvdb/v1.5.0 containing the pgx/v5 migration.
  • Cut queue/v1.2.0 containing BackpressureQueue[T].
  • Cut the next sqldb tag once gossip-V2 changes have landed (separate scope; track here so we don't forget).
  • Bump root go.mod require versions and remove the three replace directives.
  • Run go mod tidy and make tidy-module-check.

Related

  • Root go.mod lines 200–207

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No fields configured for Bug.

Projects

Status
Backlog

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions