Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build+log: use the Critifalf logging function more liberally where it makes sense #6693

Open
Roasbeef opened this issue Jun 30, 2022 · 3 comments · May be fixed by #9617
Open

build+log: use the Critifalf logging function more liberally where it makes sense #6693

Roasbeef opened this issue Jun 30, 2022 · 3 comments · May be fixed by #9617
Assignees
Labels
beginner Issues suitable for new developers good first issue Issues suitable for first time contributors to LND logging Related to the logging / debug output functionality safety General label for issues/PRs related to the safety of using the software

Comments

@Roasbeef
Copy link
Member

A few weeks ago, one of my routing nodes had its disk fill up. I didn't detect the problem until I attempted to poke it, realized something was up, then saw all the errors in the log. I think the node was running for a day or so in this state. Thankfully, I was able to shut it down, increase the partition size and restart w/o any weird force closes or breaches or w/e.

Our logging infra has a Criticalf formatting function that'll log the error, then immediately shutdown. In my case, if we were using this logging mode when we see errors like this, my node would've cleanly shut down the first time, potentially never restarting, which would've triggered some monitoring I have set up.

A disk filling up is just one case I can think of. Other may include: no free file descriptors. Alternatively, if I had the healtcheck on I would've caught this, but imo we still want this sort of log-then-crash behavior to for situations we know we can't recover from.

@Roasbeef Roasbeef added beginner Issues suitable for new developers safety General label for issues/PRs related to the safety of using the software logging Related to the logging / debug output functionality labels Jun 30, 2022
@Roasbeef Roasbeef changed the title loggign: use the Critifalf logging function more liberally where it makes sense build+log: use the Critifalf logging function more liberally where it makes sense Jun 30, 2022
@Chinwendu20
Copy link
Contributor

Please I would like to work on this

@ziggie1984 ziggie1984 added the good first issue Issues suitable for first time contributors to LND label Apr 15, 2024
@arnav-makkar
Copy link

@ziggie1984 Is anyone actively working on this issue? If not, please assign this to me.

Thanks

@ziggie1984
Copy link
Collaborator

cc @saubyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Issues suitable for new developers good first issue Issues suitable for first time contributors to LND logging Related to the logging / debug output functionality safety General label for issues/PRs related to the safety of using the software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants