Skip to content

Commit 10cb04b

Browse files
Merge pull request #51 from lightstep/sarah/LS-5226
LS-5226: Update instructions for generating thrift
2 parents 5cae747 + 86cf200 commit 10cb04b

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ test: build
6161

6262
# LightStep-specific: rebuilds the LightStep thrift protocol files. Assumes
6363
# the command is run within the LightStep development environment (i.e. the
64-
# LIGHTSTEP_HOME environment variable is set).
64+
# MONO_REPO environment variable is set).
6565
thrift:
66-
docker run -v "$(PWD)/lightstep:/out" -v "$(LIGHTSTEP_HOME)/go/src/crouton:/data" --rm thrift:0.10.0 \
66+
docker run -v "$(PWD)/lightstep:/out" -v "$(MONO_REPO)/go/src/github.com/lightstep/common-go:/data" --rm thrift:0.10.0 \
6767
thrift -r --gen py -out /out /data/crouton.thrift
68-
python-modernize -w lightstep/crouton/
68+
python-modernize -w $(PWD)/lightstep/crouton/
6969
rm -rf lightstep/crouton/ReportingService-remote

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,13 @@ source .tox/py27/bin/activate
3333
python examples/nontrivial/main.py
3434
```
3535

36+
* [Python-Modernize](https://github.com/python-modernize/python-modernize)
37+
38+
Only required for LightStep developers
39+
```python
40+
pip install modernize
41+
```
42+
3643
## Getting Started with Tracing
3744

3845
Please see the [example programs](examples/) for examples of how to use this library. In particular:

0 commit comments

Comments
 (0)