Skip to content

Commit 816fb2c

Browse files
LS-5226: Remove lightstep.proto
It isn't needed since ligthstep_carrier_pb2.py is already present. Also added googleapis-common-protos to requirements. And responded to PR feedback.
1 parent 1c6b8fb commit 816fb2c

File tree

3 files changed

+3
-189
lines changed

3 files changed

+3
-189
lines changed

Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,5 +72,4 @@ thrift:
7272
proto:
7373
protoc --proto_path "$(PWD)/../googleapis:$(PWD)/../lightstep-tracer-common/" \
7474
--python_out="$(PWD)/lightstep" \
75-
lightstep.proto \
76-
collector.proto
75+
collector.proto

lightstep/lightstep_pb2.py

Lines changed: 0 additions & 186 deletions
This file was deleted.

setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
install_requires=['thrift==0.10.0',
1111
'jsonpickle',
1212
'six',
13-
'basictracer>=2.2,<2.3'],
13+
'basictracer>=2.2,<2.3',
14+
'googleapis-common-protos==1.5.3'],
1415
tests_require=['pytest',
1516
'sphinx',
1617
'sphinx-epytext'],

0 commit comments

Comments
 (0)