Skip to content

Add constant for "PropagationSingleKey" header #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
airstandley opened this issue Jul 23, 2019 · 1 comment
Closed

Add constant for "PropagationSingleKey" header #73

airstandley opened this issue Jul 23, 2019 · 1 comment
Assignees

Comments

@airstandley
Copy link

Recently switched over to using the LightstepBinaryPropagator to get a python app playing nice with Envoy which uses Lightstep's C++ tracer with single key propagation on.

It seemed a bit silly to have to define the header constant ourselves since this library does not appear to define it anywhere. (Apologizes if I just missed it in my search)

Adding a constant similar to https://github.com/lightstep/lightstep-tracer-cpp/blob/master/src/tracer/propagation.cpp#L26 in propagation.py would be appreciated.

@andrewhsu
Copy link

closing old issue. if this is truly desired, reopen with example of how this change can help fix a situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants