Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the tag lightstep.hostname #84

Closed
zalando-andrewhowden-com opened this issue Dec 6, 2019 · 0 comments · Fixed by #98
Closed

Add the tag lightstep.hostname #84

zalando-andrewhowden-com opened this issue Dec 6, 2019 · 0 comments · Fixed by #98
Assignees

Comments

@zalando-andrewhowden-com
Copy link

zalando-andrewhowden-com commented Dec 6, 2019

Hola crew!

I would like to propose the tag 'lightstep.hostname' is appended to this library. It is present in the Go and JavaScript libraries, and would be useful such that we do not have to append that tag to the tracing constructor manually.

See:

The practical value is to allow us to identify sick nodes for inspection. Whether it is the nodes themselves that are sick, or whether it is some condition about those nodes that is otherwise invisible to the trace (i.e. AZ, connection state or so) -- it's still useful to be able to see an identity to start the inspection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants