new: usr: Adding LightstepMetricsExporter (#14)

There are a few parts in this change:

- adding a MetricExporter for Lightstep
- refactoring LightStepSpanExporter to use protobuf directly rather than through lightstep library
- cleaning up some pylint/flake

Co-Authored-By: Diego Hurtado <[email protected]>

Author: alrex

.flake8

@@ -4,3 +4,5 @@ ignore =
   F401  # unused import, defer to pylint
   W503  # allow line breaks after binary ops, not after
   E203  # allow whitespace before ':' (https://github.com/psf/black#slices) 
+exclude =
+  src/opentelemetry/ext/lightstep/protobuf

.github/workflows/build.yml

@@ -19,12 +19,9 @@ jobs:
         pip install .
     - name: Lint with flake8
       run: |
-        pip install flake8
-        # stop the build if there are Python syntax errors or undefined names
-        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+        pip install -r dev-requirements.txt
+        make lint
     - name: Test with pytest
       run: |
-        pip install pytest
+        pip install pytest .[test]
         pytest

.isort.cfg

@@ -0,0 +1,16 @@
+[settings]
+include_trailing_comma=True
+force_grid_wrap=0
+use_parentheses=True
+line_length=79
+
+; 3 stands for Vertical Hanging Indent, e.g.
+; from third_party import (
+;     lib1,
+;     lib2,
+;     lib3,
+; )
+; docs: https://github.com/timothycrosley/isort#multi-line-output-modes
+multi_line_output=3
+skip=target
+skip_glob=**/protobuf/*

.pylintrc

@@ -70,7 +70,15 @@ confidence=
 # --enable=similarities". If you want to run only the classes checker, but have
 # no warning level messages displayed, use"--disable=all --enable=classes
 # --disable=W"
-disable=protected-access,too-many-instance-attributes,too-few-public-methods,too-many-arguments,redefined-outer-name,line-too-long,W0141
+disable=protected-access,
+    too-many-instance-attributes,
+    too-few-public-methods,
+    too-many-arguments,
+    redefined-outer-name,
+    line-too-long,
+    W0141,
+    missing-docstring,
+    bad-continuation, # leave this up to black
 
 [REPORTS]
 

CHANGELOG.md

@@ -1,5 +1,14 @@
 ## Unreleased
 
+v0.6b3
+======
+
+### Changes
+
+* Adding LightstepMetricsExporter
+* Refactor LightStepSpanExporter to remove dependency on lightstep-tracer client
+* Deprecating LightStepSpanExporter in favour of LightstepSpanExporter
+
 v0.6b2
 ======
 

Makefile

@@ -1,12 +1,17 @@
 test:
+	pip install -e .[test]
 	pytest
 
 cover:
 	pytest --cov src/opentelemetry/ext/lightstep
 
 lint:
-	pip install black
-	black .
+	black . --diff --check
+	isort --recursive . 
+	# stop the build if there are Python syntax errors or undefined names
+	flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+	# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+	flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
 
 clean-dist:
 	rm -Rf ./dist

dev-requirements.txt

@@ -0,0 +1,4 @@
+flake8
+black
+isort
+pylint

examples/tracer.py

@@ -2,16 +2,14 @@
 import os
 
 from opentelemetry import trace
-from opentelemetry.ext.lightstep import LightStepSpanExporter
+from opentelemetry.ext.lightstep import LightstepSpanExporter
 from opentelemetry.sdk.trace import TracerProvider
 from opentelemetry.sdk.trace.export import BatchExportSpanProcessor
 
-
 # configure the LightStepSpanExporter as our exporter
-exporter = LightStepSpanExporter(
+exporter = LightstepSpanExporter(
     name=os.getenv("LIGHTSTEP_SERVICE_NAME", "test-service-name"),
     token=os.getenv("LIGHTSTEP_ACCESS_TOKEN", ""),
-    verbosity=5,
     host="ingest.staging.lightstep.com",
     service_version=os.getenv("LIGHTSTEP_SERVICE_VERSION", "0.0.1"),
 )

pyproject.toml

@@ -0,0 +1,9 @@
+[tool.black]
+line-length = 79
+exclude = '''
+(
+  /(  # generated files
+    src/opentelemetry/ext/lightstep/protobuf
+  )/
+)
+'''

setup.cfg

@@ -24,10 +24,16 @@ package_dir=
     =src
 packages=find_namespace:
 install_requires =
-    thrift >= 0.10.0
-    opentelemetry-api >= 0.6b0
-    opentelemetry-sdk >= 0.6b0
-    lightstep
+    backoff~=1.10.0
+    googleapis-common-protos>=1.5.3,<2.0
+    protobuf>3.7.1,<4.0
+    requests>=2.19,<3.0
+    opentelemetry-api == 0.6b0
+    opentelemetry-sdk == 0.6b0
+
+[options.extras_require]
+test =
+    httpretty~=1.0.2
 
 [options.packages.find]
 where = src