Refactor and improve test coverage a bit #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract common test setup and execution logic from three test methods (testLoginAction, testLoginActionWithOpenID, testLoginActionWithNonIsolatedResumeOpenURL) into reusable helper methods: - setupSessionStub(): Centralized session stub configuration - performLoginTest(): Parameterized login test execution with support for different permissions, OpenID expectations, and URL resume methods This reduces code duplication from ~150 lines to ~25 lines while maintaining all original test functionality and assertions.
Add 5 focused test methods for UIWindow.findKeyWindow() and UIViewController.topMost: - testFindKeyWindowWithCreatedWindow: Tests key window detection - testTopMostViewControllerWithSetup: Tests basic top-most controller finding - testTopMostViewControllerWithPresentation: Tests single presentation layer - testTopMostViewControllerWithNestedPresentation: Tests nested presentations - testWindowWithoutRootViewController: Tests edge case handling These tests eliminate non-deterministic conditional patterns and provide comprehensive coverage with reduced code duplication (~130 to ~85 lines).
…retry mechanism This commit adds three new test methods to LoginManagerTests.swift that significantly improve test coverage for the exchangeToken method's error handling logic: 1. testExchangeTokenWithNonNetworkError: Tests that non-network errors directly call invokeFailure without retry attempts 2. testExchangeTokenWithNetworkErrorRetrySuccess: Tests that NSURLErrorNetworkConnectionLost errors trigger the retry mechanism and succeed on the second attempt with proper 0.3s delay 3. testExchangeTokenWithNetworkErrorRetryFail: Tests that network errors fail gracefully after retry attempts are exhausted Key technical improvements: - Proper SessionDelegateStub sequencing for retry scenarios - Correct error wrapping behavior validation - Network connection lost error type distinction - Retry delay mechanism verification - Comprehensive catch block coverage in exchangeToken method These tests ensure robust error handling for token exchange operations and improve overall SDK reliability in network-unstable environments.
onevcat
temporarily deployed
to
Coverage Badge Env
GitHub Actions
Inactive
onevcat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the test coverage and simplified some test code.