Skip to content

Commit d107083

Browse files
committed
refactor(app/inbound): clean up body metrics imports
now that we have request and response layers, we use consistent paths for each. Signed-off-by: katelyn martin <[email protected]>
1 parent 1b7315d commit d107083

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

linkerd/app/inbound/src/http/router/metrics.rs

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use linkerd_app_core::{
1111
svc,
1212
};
1313
use linkerd_http_prom::{
14-
body_data::response::{BodyDataMetrics, NewRecordBodyData},
14+
body_data::{self, BodyDataMetrics},
1515
count_reqs::{NewCountRequests, RequestCount},
1616
};
1717

@@ -26,9 +26,9 @@ pub(super) fn layer<N>(
2626
N,
2727
Service = NewCountRequests<
2828
ExtractRequestCount,
29-
NewRecordBodyData<
29+
body_data::response::NewRecordBodyData<
3030
ExtractResponseBodyDataMetrics,
31-
linkerd_http_prom::body_data::request::NewRecordBodyData<
31+
body_data::request::NewRecordBodyData<
3232
N,
3333
ExtractRequestBodyDataParams,
3434
ExtractRequestBodyDataMetrics,
@@ -45,12 +45,12 @@ pub(super) fn layer<N>(
4545

4646
let body = {
4747
let extract = ExtractResponseBodyDataMetrics(response_body_data.clone());
48-
NewRecordBodyData::layer_via(extract)
48+
body_data::response::NewRecordBodyData::layer_via(extract)
4949
};
5050

5151
let request = {
5252
let extract = ExtractRequestBodyDataParams(request_body_data.clone());
53-
linkerd_http_prom::body_data::request::NewRecordBodyData::new(extract)
53+
body_data::request::NewRecordBodyData::new(extract)
5454
};
5555

5656
svc::layer::mk(move |inner| count.layer(body.layer(request.layer(inner))))
@@ -72,8 +72,8 @@ pub struct ExtractRequestCount(pub RequestCountFamilies);
7272

7373
#[derive(Clone, Debug)]
7474
pub struct ResponseBodyFamilies {
75-
grpc: linkerd_http_prom::body_data::response::ResponseBodyFamilies<ResponseBodyDataLabels>,
76-
http: linkerd_http_prom::body_data::response::ResponseBodyFamilies<ResponseBodyDataLabels>,
75+
grpc: body_data::response::ResponseBodyFamilies<ResponseBodyDataLabels>,
76+
http: body_data::response::ResponseBodyFamilies<ResponseBodyDataLabels>,
7777
}
7878

7979
#[derive(Clone, Debug, Hash, PartialEq, Eq)]
@@ -86,8 +86,8 @@ pub struct ExtractResponseBodyDataMetrics(ResponseBodyFamilies);
8686

8787
#[derive(Clone, Debug)]
8888
pub struct RequestBodyFamilies {
89-
grpc: linkerd_http_prom::body_data::request::RequestBodyFamilies<RequestBodyDataLabels>,
90-
http: linkerd_http_prom::body_data::request::RequestBodyFamilies<RequestBodyDataLabels>,
89+
grpc: body_data::request::RequestBodyFamilies<RequestBodyDataLabels>,
90+
http: body_data::request::RequestBodyFamilies<RequestBodyDataLabels>,
9191
}
9292

9393
#[derive(Clone, Debug, Hash, PartialEq, Eq)]
@@ -189,12 +189,12 @@ impl ResponseBodyFamilies {
189189
pub fn register(reg: &mut prom::Registry) -> Self {
190190
let grpc = {
191191
let reg = reg.sub_registry_with_prefix("grpc");
192-
linkerd_http_prom::body_data::response::ResponseBodyFamilies::register(reg)
192+
body_data::response::ResponseBodyFamilies::register(reg)
193193
};
194194

195195
let http = {
196196
let reg = reg.sub_registry_with_prefix("http");
197-
linkerd_http_prom::body_data::response::ResponseBodyFamilies::register(reg)
197+
body_data::response::ResponseBodyFamilies::register(reg)
198198
};
199199

200200
Self { grpc, http }
@@ -204,7 +204,7 @@ impl ResponseBodyFamilies {
204204
fn family(
205205
&self,
206206
variant: PermitVariant,
207-
) -> &linkerd_http_prom::body_data::response::ResponseBodyFamilies<ResponseBodyDataLabels> {
207+
) -> &body_data::response::ResponseBodyFamilies<ResponseBodyDataLabels> {
208208
let Self { grpc, http } = self;
209209
match variant {
210210
PermitVariant::Grpc => grpc,
@@ -270,12 +270,12 @@ impl RequestBodyFamilies {
270270
pub fn register(reg: &mut prom::Registry) -> Self {
271271
let grpc = {
272272
let reg = reg.sub_registry_with_prefix("grpc");
273-
linkerd_http_prom::body_data::request::RequestBodyFamilies::register(reg)
273+
body_data::request::RequestBodyFamilies::register(reg)
274274
};
275275

276276
let http = {
277277
let reg = reg.sub_registry_with_prefix("http");
278-
linkerd_http_prom::body_data::request::RequestBodyFamilies::register(reg)
278+
body_data::request::RequestBodyFamilies::register(reg)
279279
};
280280

281281
Self { grpc, http }
@@ -285,7 +285,7 @@ impl RequestBodyFamilies {
285285
fn family(
286286
&self,
287287
variant: PermitVariant,
288-
) -> &linkerd_http_prom::body_data::request::RequestBodyFamilies<RequestBodyDataLabels> {
288+
) -> &body_data::request::RequestBodyFamilies<RequestBodyDataLabels> {
289289
let Self { grpc, http } = self;
290290
match variant {
291291
PermitVariant::Grpc => grpc,

0 commit comments

Comments
 (0)