fix: fix a bug that Ast instance doesn't have parent (#3)

* fix: fix a bug that Ast instance doesn't have parent

* test: update unit test for node that have parent

* fix(test): fix global configure test potential problem

Author: yuzhanglong

__tests__/index.spec.ts

@@ -1,11 +1,10 @@
 import * as unified from 'unified';
 import * as markdown from 'remark-parse';
-import { Ast, Plugin } from '../src/';
+import { Ast, Plugin } from '../src';
 import { setGlobalConfig, getGlobalConfig } from '../src/global';
 import { TestPlugin } from './TestPlugin';
 
 describe('index', () => {
-
   test('exports', () => {
     expect(Ast).not.toBe(undefined);
     expect(Plugin).not.toBe(undefined);
@@ -65,6 +64,7 @@ describe('index', () => {
     expect(plugin2.doDelete).toHaveBeenCalledTimes(0);
   });
 
+
   test('get', () => {
     const ast = unified()
       .use(markdown)
@@ -77,6 +77,7 @@ describe('index', () => {
     expect(new Ast(ast).get('aaa.bbb')).toBe(undefined);
   });
 
+
   test('segment', () => {
     let md = `\`\`\`js
 cont a = 1;
@@ -103,6 +104,7 @@ const b = 2;
     expect(ast.get('children.0.children.0').segment()).toBe('Hello **world**!');
   });
 
+
   test('throwError call', () => {
     const throwErrFn = jest.fn();
     const testErrorPlugin = new TestPlugin({
@@ -121,11 +123,49 @@ const b = 2;
     });
   });
 
+
   test('global configure', () => {
     expect(getGlobalConfig()).toEqual({ typeKey: 'type', childrenKey: 'children' });
 
     setGlobalConfig({ typeKey: 'type' });
 
     expect(getGlobalConfig()).toEqual({ typeKey: 'type' });
+
+    // 上述操作有副作用，会影响下面的 tests, 需要重新复原
+    setGlobalConfig({ typeKey: 'type', childrenKey: 'children' });
+    expect(getGlobalConfig()).toEqual({ typeKey: 'type', childrenKey: 'children' });
+  });
+
+  test('should have parent in child ast', () => {
+    const mock = jest.fn((ast: Ast) => {
+      expect(ast.parent.node.type).toStrictEqual('paragraph');
+    });
+
+    class MyPlugin extends Plugin {
+      post(): void {
+      }
+
+      pre(): void {
+      }
+
+      visitor(): any {
+        return {
+          strong: mock
+        };
+      }
+    }
+
+    const a = unified()
+      .use(markdown)
+      .parse('Hello **world**!');
+
+
+    const p = new MyPlugin({
+      throwError: undefined
+    });
+
+    new Ast(a).traverse([p]);
+
+    expect(mock).toBeCalled();
   });
 });

src/Ast.ts

@@ -5,11 +5,11 @@ import { Plugin } from './Plugin';
 
 export class Ast {
   node: Unist.Node;
-  parent: Unist.Node;
+  parent: Ast;
   text: string;
   skipped: boolean;
 
-  constructor(node: Unist.Node, parent?: Unist.Parent, text?: string) {
+  constructor(node: Unist.Node, parent?: Ast, text?: string) {
     this.node = node;
     this.parent = parent;
     // 文本、代码
@@ -59,7 +59,7 @@ export class Ast {
 
     // 处理子元素
     if (Array.isArray(children) && !this.skipped) {
-      children.forEach(child => new Ast(child, undefined, this.text).process(plugins));
+      children.forEach(child => new Ast(child, this, this.text).process(plugins));
     }
   }