nvme-cli/fabrics: note an excluded target on connect under --verbose

The exclusion list governs auto-connecting orchestrators, not an explicit
"nvme connect", so connect must never be blocked by it. But an operator
who hand-connects a controller they previously excluded is overriding
their own opt-out, often unknowingly. Under --verbose, consult the list
and print a note when the target matches, making the override visible
without changing behaviour. Document the courtesy in EXCLUSIONS.md.

Signed-off-by: Martin Belanger <martin.belanger@dell.com>

Author: Martin Belanger

fabrics.c

@@ -770,6 +770,26 @@ int fabrics_connect(const char *desc, int argc, char **argv)
 	if (config_file)
 		return libnvmf_connect_config_json(ctx, fctx);
 
+	/*
+	 * The exclusion list governs auto-connecting orchestrators, not an
+	 * explicit "nvme connect", so we never block it here. But under
+	 * --verbose, note when the target matches an exclusion entry so the
+	 * operator knows they are overriding their own opt-out.
+	 */
+	if (nvme_args.verbose) {
+		struct libnvmf_tid *tid;
+
+		tid = libnvmf_tid_from_fields(fa.transport, fa.traddr,
+					      fa.trsvcid, fa.subsysnqn,
+					      fa.host_traddr, fa.host_iface,
+					      fa.hostnqn, fa.hostid);
+		if (tid && libnvmf_exclusion_match(ctx, tid))
+			fprintf(stderr,
+				"Note: %s is on the exclusion list; connecting anyway\n",
+				fa.subsysnqn ? fa.subsysnqn : "this controller");
+		libnvmf_tid_free(tid);
+	}
+
 	ret = libnvmf_connect(ctx, fctx);
 	if (ret) {
 		fprintf(stderr, "failed to connect: %s\n",

libnvme/design/EXCLUSIONS.md

@@ -94,9 +94,9 @@ if (libnvmf_exclusion_match(ctx, tid))
         continue;   /* administrator excluded this controller */
 ```
 
-`libnvmf_exclusion_match()` re-reads the directory on every call (no caching), so an edit takes effect on the next connection attempt without restarting anything. This is the only API an orchestrator needs; the create/add/remove calls are for the management tooling.
+`libnvmf_exclusion_match()` re-reads the files on every call (no caching), so an edit takes effect on the next connection attempt without restarting anything. This is the only API an orchestrator needs; the create/add/remove calls are for the management tooling.
 
-The match is by design *not* applied to `nvme connect <args>` or `nvme disconnect <device>`: those are single, targeted human actions where the operator's intent is explicit. The list governs the *orchestrating* paths that decide on their own.
+The match is by design *not* allowed to **block** `nvme connect <args>` or `nvme disconnect <device>`: those are single, targeted human actions where the operator's intent is explicit. The list governs the *orchestrating* paths that decide on their own. As a courtesy, `nvme connect --verbose` does *consult* the list and prints a note when the target matches — a heads-up that you are overriding your own opt-out — but it still connects.
 
 ## Managing the list