Address CodeQL warnings

[nhosoi]

CodeQL reports following warnings. It'd be preferable to clean them up.
codeql.network.txt

This is an incomplete pull request containing useful discussions.
#558

[tyll]

Thanks, how is the CodeQL report generated? Since CodeQL is enabled, I was expecting the results to be part of the current checks but, for example at: https://github.com/linux-system-roles/network/actions/runs/4138105148

[nhosoi]

Thanks, how is the CodeQL report generated?

We ported the command lines that appeared in the codeql action to https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/test_scripts/runcodeql.sh. Actually, the result contains warnings in addition to the failures. And the network role is free from "failures".

[tyll]

Ah, thanks for the clarification. Now I found the warnings at https://github.com/linux-system-roles/network/security/code-scanning

[nhosoi]

@tyll, I've opened a pr for the tox command tox -e codeql.
linux-system-roles/tox-lsr#107

It clearly states as follows.

CodeQL result file on network:
 - failed: /path/to/network/.tox/codeql/results/codeql-failed-run.sarif
 - all: /path/to/network/.tox/codeql/results/python.sarif
CODEQL RESULT
[
  {
    "ruleId": "py/empty-except",
    <<snip>>
    "partialFingerprints": {
      "primaryLocationLineHash": "dd9fcbb08231241c:1",
      "primaryLocationStartColumnFingerprint": "37"
    }
  }
]
PASS: Found 29 items; none of them are failures.
___________________________________ summary ____________________________________
  codeql: commands succeeded
  congratulations :)