Skip to content

Commit 05cef2c

Browse files
committed
rust: kunit: use C-string literals to clean warning
Starting with upstream Rust commit a5e3a3f9b6bd ("move `manual_c_str_literals` to complexity"), to be released in Rust 1.83.0 [1], Clippy now warns on `manual_c_str_literals` by default, e.g.: error: manually constructing a nul-terminated string --> rust/kernel/kunit.rs:21:13 | 21 | b"\x013%pA\0".as_ptr() as _, | ^^^^^^^^^^^^^ help: use a `c""` literal: `c"\x013%pA"` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals = note: `-D clippy::manual-c-str-literals` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::manual_c_str_literals)]` Apply the suggestion to clean up the warnings. Link: rust-lang/rust-clippy#13263 [1] Reviewed-by: Trevor Gross <[email protected]> Reviewed-by: Benno Lossin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>
1 parent 4c66f83 commit 05cef2c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rust/kernel/kunit.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pub fn err(args: fmt::Arguments<'_>) {
1818
#[cfg(CONFIG_PRINTK)]
1919
unsafe {
2020
bindings::_printk(
21-
b"\x013%pA\0".as_ptr() as _,
21+
c"\x013%pA".as_ptr() as _,
2222
&args as *const _ as *const c_void,
2323
);
2424
}
@@ -34,7 +34,7 @@ pub fn info(args: fmt::Arguments<'_>) {
3434
#[cfg(CONFIG_PRINTK)]
3535
unsafe {
3636
bindings::_printk(
37-
b"\x016%pA\0".as_ptr() as _,
37+
c"\x016%pA".as_ptr() as _,
3838
&args as *const _ as *const c_void,
3939
);
4040
}

0 commit comments

Comments
 (0)