Skip to content

Commit cc70ce8

Browse files
committed
Merge tag 'gpio-fixes-for-v6.12-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux
Pull gpio fixes from Bartosz Golaszewski: - fix a potential NULL-pointer dereference in gpiolib core - fix a probe() regression from the v6.12 merge window and an older bug leading to missed interrupts in gpio-davinci * tag 'gpio-fixes-for-v6.12-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux: gpiolib: Fix potential NULL pointer dereference in gpiod_get_label() gpio: davinci: Fix condition for irqchip registration gpio: davinci: fix lazy disable
2 parents 2f91ff2 + 7b99b5a commit cc70ce8

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

drivers/gpio/gpio-davinci.c

+5-5
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ static int davinci_gpio_probe(struct platform_device *pdev)
253253
* serve as EDMA event triggers.
254254
*/
255255

256-
static void gpio_irq_disable(struct irq_data *d)
256+
static void gpio_irq_mask(struct irq_data *d)
257257
{
258258
struct davinci_gpio_regs __iomem *g = irq2regs(d);
259259
uintptr_t mask = (uintptr_t)irq_data_get_irq_handler_data(d);
@@ -262,7 +262,7 @@ static void gpio_irq_disable(struct irq_data *d)
262262
writel_relaxed(mask, &g->clr_rising);
263263
}
264264

265-
static void gpio_irq_enable(struct irq_data *d)
265+
static void gpio_irq_unmask(struct irq_data *d)
266266
{
267267
struct davinci_gpio_regs __iomem *g = irq2regs(d);
268268
uintptr_t mask = (uintptr_t)irq_data_get_irq_handler_data(d);
@@ -288,8 +288,8 @@ static int gpio_irq_type(struct irq_data *d, unsigned trigger)
288288

289289
static struct irq_chip gpio_irqchip = {
290290
.name = "GPIO",
291-
.irq_enable = gpio_irq_enable,
292-
.irq_disable = gpio_irq_disable,
291+
.irq_unmask = gpio_irq_unmask,
292+
.irq_mask = gpio_irq_mask,
293293
.irq_set_type = gpio_irq_type,
294294
.flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE,
295295
};
@@ -472,7 +472,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
472472
return PTR_ERR(clk);
473473
}
474474

475-
if (chips->gpio_unbanked) {
475+
if (!chips->gpio_unbanked) {
476476
irq = devm_irq_alloc_descs(dev, -1, 0, ngpio, 0);
477477
if (irq < 0) {
478478
dev_err(dev, "Couldn't allocate IRQ numbers\n");

drivers/gpio/gpiolib.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,12 @@ const char *gpiod_get_label(struct gpio_desc *desc)
114114
srcu_read_lock_held(&desc->gdev->desc_srcu));
115115

116116
if (test_bit(FLAG_USED_AS_IRQ, &flags))
117-
return label->str ?: "interrupt";
117+
return label ? label->str : "interrupt";
118118

119119
if (!test_bit(FLAG_REQUESTED, &flags))
120120
return NULL;
121121

122-
return label->str;
122+
return label ? label->str : NULL;
123123
}
124124

125125
static void desc_free_label(struct rcu_head *rh)

0 commit comments

Comments
 (0)