Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] [Peer] definition within generated wg0.conf should be templated #335

Closed
1 task done
greigm opened this issue May 4, 2024 · 11 comments · May be fixed by #345
Closed
1 task done

[FEAT] [Peer] definition within generated wg0.conf should be templated #335

greigm opened this issue May 4, 2024 · 11 comments · May be fixed by #345

Comments

@greigm
Copy link

greigm commented May 4, 2024

Is this a new feature request?

  • I have searched the existing issues

Wanted change

I use a grafana dashboard which relies on an exporter which in turn looks for # friendly_name=${PEER_ID} to export meaningful peer names to grafana. It would be nice if the [Peer] definitions inside wg0.conf were templatable in the same way that the [Interface] part is, and each Peer config is. Perhaps this is already possible, but from my initial (poor) reading of the code and the docs, it doesn't seem to be.

Reason for change

Extra flexible configuration. Compatibility with other software.

Proposed code change

No response

@greigm greigm added the enhancement New feature or request label May 4, 2024
Copy link

github-actions bot commented May 4, 2024

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@greigm
Copy link
Author

greigm commented Jun 4, 2024

I am unsure what else I can do to keep this feature request alive.

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@nonk123
Copy link

nonk123 commented Jul 12, 2024

I've got the same usecase and I completely agree. I'll try to solve this in a fork and maybe submit a PR.

@nonk123
Copy link

nonk123 commented Jul 14, 2024

@greigm I've had lots of success using the fork so far. You can pull the image from the link in the PR. You'll just need to regenerate your wg0.conf by deleting it and restarting the container.

@greigm
Copy link
Author

greigm commented Jul 14, 2024

Amazing, thanks so much @nonk123. I'll grab it now.

@greigm
Copy link
Author

greigm commented Jul 14, 2024

Yep - works like a charm. Nice work! Thanks.

@nonk123
Copy link

nonk123 commented Jul 14, 2024

You're welcome! Thanks for giving me a push to implement this too.

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI LinuxServer-CI closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants