revert: PR #1090 ensure EAI_AGAIN middleware is added to new file systems TDE-1268 (#1093)

Reverts "fix: ensure EAI_AGAIN middleware is added to new file systems
TDE-1268 (#1090)"

This reverts commit 48ec902.

#### Motivation

Release v4.5.1 of Argo Tasks caused workflows (e.g. when running
`tileindex-validate`) to fail with the following error:

```json
{"level":60,"time":1727812404265,"pid":14,"hostname":"test-afage-tileindex-validate-sq9t2-main-1070049358","id":"01J94TA0KEYQ4MZCHHXCPCMQYY","err":{"type":"TypeError","message":"Cannot set properties of undefined (setting 'onFileSystemCreated')","stack":"TypeError: Cannot set properties of undefined (setting 'onFileSystemCreated')\n    at setupS3FileSystem (file:///app/fs.register.js:68:46)\n    at fsClient.credentials.onFileSystemCreated (file:///app/fs.register.js:72:13)\n    at FsAwsS3ProviderV3.find (file:///app/node_modules/@chunkd/source-aws/build/provider.js:100:85)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async FsAwsS3V3.details (file:///app/node_modules/@chunkd/source-aws/build/s3.fs.js:90:31)\n    at async asyncFilter (file:///app/utils/chunk.js:7:22)\n    at async FileSystemAbstraction.toArray (file:///app/node_modules/@chunkd/core/build/index.js:49:22)\n    at async getFiles (file:///app/utils/chunk.js:64:26)\n    at async Object.load (file:///app/commands/tileindex-validate/tileindex.validate.js:27:23)\n    at async Object.handler (file:///app/commands/tileindex-validate/tileindex.validate.js:198:23)"},"msg":"Command:Failed"}
```

#### Modification

Revert PR #1090.

#### Checklist

- [x] Tests updated
- [ ] Docs updated N/A
- [x] Issue linked in Title

Author: amfage

src/__test__/fs.test.ts

@@ -4,7 +4,7 @@ import { S3Client } from '@aws-sdk/client-s3';
 import { FileSystem } from '@chunkd/core';
 import { fsa } from '@chunkd/fs';
 import { AwsCredentialConfig, FsAwsS3 } from '@chunkd/source-aws';
-import { FsAwsS3V3 } from '@chunkd/source-aws-v3';
+import { FsAwsS3V3, S3LikeV3 } from '@chunkd/source-aws-v3';
 import { BuildMiddleware, FinalizeRequestMiddleware, MetadataBearer } from '@smithy/types';
 
 import { logger } from './log.js';
@@ -63,48 +63,34 @@ export function eaiAgainBuilder(timeout: (attempt: number) => number): BuildMidd
   return eaiAgain;
 }
 
-/**
- * When a new AWS file system is created copy across the middleware, but only if the middleware does not exist
- *
- * @param fsClient Filesystem to setup
- */
-export function setupS3FileSystem(fsClient: FsAwsS3V3): void {
-  fsClient.credentials.onFileSystemCreated = (acc: AwsCredentialConfig, fs: FileSystem): void => {
-    logger.debug({ prefix: acc.prefix, roleArn: acc.roleArn }, 'FileSystem:Register');
-
-    // TODO this cast can be removed once chunkd is upgraded
-    if (fs.protocol === 's3') setupS3FileSystem(fs as FsAwsS3V3);
-
-    fsa.register(acc.prefix, fs);
-  };
+const client = new S3Client();
+export const s3Fs = new FsAwsS3V3(client);
+client.middlewareStack.add(
+  eaiAgainBuilder((attempt: number) => 100 + attempt * 1000),
+  { name: 'EAI_AGAIN', step: 'build' },
+);
+client.middlewareStack.add(fqdn, { name: 'FQDN', step: 'finalizeRequest' });
 
-  // There doesnt appear to be a has or find, so the only option is to list all middleware
-  // which returns a list in a format: "FQDN - finalizeRequest"
-  const middleware = fsClient.client.middlewareStack.identify();
+FsAwsS3.MaxListCount = 1000;
+s3Fs.credentials.onFileSystemCreated = (acc: AwsCredentialConfig, fs: FileSystem): void => {
+  logger.debug({ prefix: acc.prefix, roleArn: acc.roleArn }, 'FileSystem:Register');
 
-  if (middleware.find((f) => f.startsWith('FQDN ')) == null) {
+  if (fs.protocol === 's3') {
+    // TODO this cast can be removed once chunkd is upgraded
+    const fsS3 = fs as FsAwsS3V3;
+    const fsClient = fsS3.s3 as S3LikeV3;
     fsClient.client.middlewareStack.add(fqdn, { name: 'FQDN', step: 'finalizeRequest' });
   }
 
-  if (middleware.find((f) => f.startsWith('EAI_AGAIN ')) == null) {
-    fsClient.client.middlewareStack.add(
-      eaiAgainBuilder((attempt: number) => 100 + attempt * 1000),
-      { name: 'EAI_AGAIN', step: 'build' },
-    );
-  }
-}
-
-FsAwsS3.MaxListCount = 1000;
+  fsa.register(acc.prefix, fs);
+};
 
 function splitConfig(x: string): string[] {
   if (x.startsWith('[')) return JSON.parse(x) as string[];
   return x.split(',');
 }
 
 export function registerFileSystem(opts: { config?: string }): void {
-  const s3Fs = new FsAwsS3V3(new S3Client());
-  setupS3FileSystem(s3Fs);
-
   fsa.register('s3://', s3Fs);
 
   const configPath = opts.config ?? process.env['AWS_ROLE_CONFIG_PATH'];