fix(tileindex-validate): log errors when validating presets fail (#1180)

#### Motivation

When validation fails the errors are logged as a `Error` object, by
default the logger does not seralize classes so it gets logged as
`"reason": {}` which is very unhelpful to know why something failed

#### Modification

When failing a validation check, log out the reason as a string, the
file that failed and the preset that was being checked at the time.

#### Verification

Added unit tests for the preset validation

Author: blacha

src/commands/tileindex-validate/__test__/tileindex.validate.test.ts

@@ -7,6 +7,7 @@ import { FsMemory } from '@chunkd/source-memory';
 import { BBox } from '@linzjs/geojson';
 import { FeatureCollection } from 'geojson';
 
+import { logger } from '../../../log.js';
 import { MapSheetData } from '../../../utils/__test__/mapsheet.data.js';
 import { GridSize, MapSheet } from '../../../utils/mapsheet.js';
 import { createTiff } from '../../common.js';
@@ -19,6 +20,7 @@ import {
   reprojectIfNeeded,
   TiffLoader,
   validate8BitsTiff,
+  validatePreset,
 } from '../tileindex.validate.js';
 import { FakeCogTiff } from './tileindex.validate.data.js';
 
@@ -329,6 +331,23 @@ describe('is8BitsTiff', () => {
   });
 });
 
+describe.only('validatePreset', () => {
+  it('should validate multiple tiffs', async (t) => {
+    const test16bTiff = await createTiff('./src/commands/tileindex-validate/__test__/data/16b.tiff');
+    const test8bTiff = await createTiff('./src/commands/tileindex-validate/__test__/data/8b.tiff');
+    const fatalStub = t.mock.method(logger, 'fatal');
+    await assert.rejects(validatePreset('webp', [test16bTiff, test16bTiff, test8bTiff]), {
+      name: 'Error',
+      message: `Tiff preset:"webp" validation failed`,
+    });
+
+    assert.equal(fatalStub.mock.callCount(), 2); // Should be called per tiff failure
+    const opts = fatalStub.mock.calls[0]?.arguments[0] as unknown as Record<string, string>;
+    assert.equal(opts['preset'], 'webp');
+    assert.ok(opts['reason']?.includes('is not a 8 bits TIFF'));
+  });
+});
+
 describe('TiffFromMisalignedTiff', () => {
   it('should properly identify all tiles under a tiff not aligned to our grid', async () => {
     const fakeTiffCover4 = FakeCogTiff.fromTileName('CJ09');

src/commands/tileindex-validate/tileindex.validate.ts

@@ -122,21 +122,20 @@ export const GridSizeFromString: Type<string, GridSize> = {
  * @param preset preset to validate against
  * @param tiffs tiffs to validate.
  */
-async function validatePreset(preset: string, tiffs: Tiff[]): Promise<void> {
-  let rejected: boolean = false;
+export async function validatePreset(preset: string, tiffs: Tiff[]): Promise<void> {
+  let rejected = false;
 
   if (preset === 'webp') {
-    const promises = tiffs.map((f) => validate8BitsTiff(f));
-    const results = await Promise.allSettled(promises);
-    for (const r of results) {
-      if (r.status === 'rejected') {
+    const promises = tiffs.map((f) => {
+      return validate8BitsTiff(f).catch((err) => {
+        logger.fatal({ reason: String(err), source: f.source.url.href, preset }, 'Tiff:ValidatePreset:failed');
         rejected = true;
-        logger.fatal({ reason: r.reason as string }, 'Tiff:ValidatePreset:failed');
-      }
-    }
+      });
+    });
+    await Promise.allSettled(promises);
   }
 
-  if (rejected) throw new Error('Tiff preset validation failed');
+  if (rejected) throw new Error(`Tiff preset:"${preset}" validation failed`);
 }
 
 /**