generated from linz/template-javascript-hello-world
-
Notifications
You must be signed in to change notification settings - Fork 4
feat(stac-collection-output): get scale from ODR dataset TDE-1673 #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
reviewed
Oct 23, 2025
schmidtnz
reviewed
Oct 30, 2025
schmidtnz
reviewed
Oct 30, 2025
schmidtnz
reviewed
Oct 30, 2025
schmidtnz
requested changes
Oct 30, 2025
Contributor
schmidtnz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some NITs and check if output needs to be optional on writeSetupFiles
paulfouquet
reviewed
Oct 30, 2025
schmidtnz
previously approved these changes
Oct 30, 2025
paulfouquet
approved these changes
Nov 2, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
🤖 I have created a release *beep* *boop* --- ## [5.0.0](v4.21.2...v5.0.0) (2025-11-02) ### ⚠ BREAKING CHANGES * **tileindex-validate:** automatically select scale of output tiles TDE-1674 ([#1287](#1287)) ### Features * **stac-collection-output:** get scale from ODR dataset TDE-1673 ([#1282](#1282)) ([73361b5](73361b5)) * **tileindex-validate:** automatically select scale of output tiles TDE-1674 ([#1287](#1287)) ([e2228f8](e2228f8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Nov 3, 2025
📣 Merge after linz/argo-tasks#1282 is merged and released in Argo Tasks v5. **Motivation** The new tileindex-validate command behaviour requires the scale of existing datasets to override automatic tiling, if necessary. This requires an extra workflow task `tpl-at-stac-collection-output`. **Modifications** Added a new workflow `tpl-at-stac-collection-output` to read the ODR collection and output the scale as an Argo Workflows output parameter. Other parameters can be added later if necessary. **Verification** Workflow run with [Argo Tasks PR container](linz/argo-tasks#1282).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The new
tileindex-validatecommand behaviour requires the scale of existing datasets to override automatic tiling, if necessary.Modifications
Added a new command
stac-collection-outputto read the ODR collection and output the scale so it can be used as an Argo Workflows parameters. Other parameters can be added later if necessary.Verification
Unit tests and workflow run with PR container.