Skip to content

Conversation

@amfage
Copy link
Contributor

@amfage amfage commented Oct 21, 2025

Motivation

The new tileindex-validate command behaviour requires the scale of existing datasets to override automatic tiling, if necessary.

Modifications

Added a new command stac-collection-output to read the ODR collection and output the scale so it can be used as an Argo Workflows parameters. Other parameters can be added later if necessary.

Verification

Unit tests and workflow run with PR container.

@amfage amfage changed the title Feat/get scale from existing dataset tde 1673 feat: get scale from ODR dataset TDE-1673 Oct 21, 2025
@amfage amfage added the container Build a container from a pull request label Oct 22, 2025
@amfage amfage changed the title feat: get scale from ODR dataset TDE-1673 feat(stac-collection-output): get scale from ODR dataset TDE-1673 Oct 23, 2025
@amfage amfage marked this pull request as ready for review October 23, 2025 01:01
@amfage amfage requested review from a team as code owners October 23, 2025 01:01
@amfage amfage marked this pull request as draft October 23, 2025 02:16
@amfage amfage added container Build a container from a pull request and removed container Build a container from a pull request labels Oct 23, 2025
@amfage amfage added container Build a container from a pull request and removed container Build a container from a pull request labels Oct 23, 2025
@amfage amfage marked this pull request as ready for review October 23, 2025 02:53
Copy link
Contributor

@schmidtnz schmidtnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some NITs and check if output needs to be optional on writeSetupFiles

schmidtnz
schmidtnz previously approved these changes Oct 30, 2025
@amfage amfage added this pull request to the merge queue Nov 2, 2025
Merged via the queue into master with commit 73361b5 Nov 2, 2025
3 checks passed
@amfage amfage deleted the feat/get-scale-from-existing-dataset-tde-1673 branch November 2, 2025 22:29
@linz-li-bot linz-li-bot mentioned this pull request Nov 2, 2025
github-merge-queue bot pushed a commit that referenced this pull request Nov 3, 2025
🤖 I have created a release *beep* *boop*
---


## [5.0.0](v4.21.2...v5.0.0)
(2025-11-02)


### ⚠ BREAKING CHANGES

* **tileindex-validate:** automatically select scale of output tiles
TDE-1674 ([#1287](#1287))

### Features

* **stac-collection-output:** get scale from ODR dataset TDE-1673
([#1282](#1282))
([73361b5](73361b5))
* **tileindex-validate:** automatically select scale of output tiles
TDE-1674 ([#1287](#1287))
([e2228f8](e2228f8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot pushed a commit to linz/topo-workflows that referenced this pull request Nov 3, 2025
📣 Merge after linz/argo-tasks#1282 is
merged and released in Argo Tasks v5.

**Motivation**
The new tileindex-validate command behaviour requires the scale of
existing datasets to override automatic tiling, if necessary. This
requires an extra workflow task `tpl-at-stac-collection-output`.

**Modifications**
Added a new workflow `tpl-at-stac-collection-output` to read the ODR
collection and output the scale as an Argo Workflows output parameter.
Other parameters can be added later if necessary.

**Verification**
Workflow run with [Argo Tasks PR
container](linz/argo-tasks#1282).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

container Build a container from a pull request

Development

Successfully merging this pull request may close these issues.

4 participants