configurable ringing interval (#328)

* configurable ringing interval

* change parameter type

Author: zusrut

pkg/config/config.go

@@ -61,17 +61,18 @@ type Config struct {
 	ApiSecret string             `yaml:"api_secret"` // required (env LIVEKIT_API_SECRET)
 	WsUrl     string             `yaml:"ws_url"`     // required (env LIVEKIT_WS_URL)
 
-	HealthPort        int                 `yaml:"health_port"`
-	PrometheusPort    int                 `yaml:"prometheus_port"`
-	PProfPort         int                 `yaml:"pprof_port"`
-	SIPPort           int                 `yaml:"sip_port"`        // announced SIP signaling port
-	SIPPortListen     int                 `yaml:"sip_port_listen"` // SIP signaling port to listen on
-	SIPHostname       string              `yaml:"sip_hostname"`
-	TLS               *TLSConfig          `yaml:"tls"`
-	RTPPort           rtcconfig.PortRange `yaml:"rtp_port"`
-	Logging           logger.Config       `yaml:"logging"`
-	ClusterID         string              `yaml:"cluster_id"` // cluster this instance belongs to
-	MaxCpuUtilization float64             `yaml:"max_cpu_utilization"`
+	HealthPort         int                 `yaml:"health_port"`
+	PrometheusPort     int                 `yaml:"prometheus_port"`
+	PProfPort          int                 `yaml:"pprof_port"`
+	SIPPort            int                 `yaml:"sip_port"`        // announced SIP signaling port
+	SIPPortListen      int                 `yaml:"sip_port_listen"` // SIP signaling port to listen on
+	SIPHostname        string              `yaml:"sip_hostname"`
+	SIPRingingInterval time.Duration       `yaml:"sip_ringing_interval"` // from 1 sec up to 60 (default '1s')
+	TLS                *TLSConfig          `yaml:"tls"`
+	RTPPort            rtcconfig.PortRange `yaml:"rtp_port"`
+	Logging            logger.Config       `yaml:"logging"`
+	ClusterID          string              `yaml:"cluster_id"` // cluster this instance belongs to
+	MaxCpuUtilization  float64             `yaml:"max_cpu_utilization"`
 
 	UseExternalIP bool   `yaml:"use_external_ip"`
 	LocalNet      string `yaml:"local_net"` // local IP net to use, e.g. 192.168.0.0/24

pkg/sip/inbound.go

@@ -1088,8 +1088,7 @@ func (c *sipInbound) StartRinging() {
 	tx := c.inviteTx
 	cancels := tx.Cancels()
 	go func() {
-		// TODO: check spec for the exact interval
-		ticker := time.NewTicker(time.Second)
+		ticker := time.NewTicker(c.s.conf.SIPRingingInterval)
 		defer ticker.Stop()
 		for {
 			select {

pkg/sip/service.go

@@ -93,6 +93,10 @@ func NewService(region string, conf *config.Config, mon *stats.Monitor, log logg
 	if s.conf.SIPHostname != "" {
 		log.Infow("using hostname", "hostname", s.conf.SIPHostname)
 	}
+	if s.conf.SIPRingingInterval < 1*time.Second || s.conf.SIPRingingInterval > 60*time.Second {
+		s.conf.SIPRingingInterval = 1 * time.Second
+		log.Infow("ringing interval", "seconds", s.conf.SIPRingingInterval)
+	}
 	return s, nil
 }