Skip to content

Commit a7b71f0

Browse files
authored
Fix version detection for pre-release versions (#175)
Pre-release versions like 0.3.0rc2 were incorrectly identified as < 0.3.0 due to PEP 440 semantics, causing the server to use a module path without a __main__ entry point. This resulted in containers exiting immediately with code 0. Use base_version for comparison to ignore pre-release suffixes Signed-off-by: Derek Higgins <[email protected]>
1 parent 064ab7a commit a7b71f0

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

controllers/resource_helper.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,14 @@ try:
6464
print(f'Detected llama-stack version: {llama_version}', file=sys.stderr)
6565
6666
v = pkg_version.parse(llama_version)
67+
# Use base_version to ignore pre-release/post-release/dev suffixes
68+
# This ensures that 0.3.0rc2, 0.3.0alpha1, etc. are treated as 0.3.0
69+
base_v = pkg_version.parse(v.base_version)
6770
68-
if v < pkg_version.parse('0.2.17'):
71+
if base_v < pkg_version.parse('0.2.17'):
6972
print('Using legacy module path (llama_stack.distribution.server.server)', file=sys.stderr)
7073
print(0)
71-
elif v < pkg_version.parse('0.3.0'):
74+
elif base_v < pkg_version.parse('0.3.0'):
7275
print('Using core module path (llama_stack.core.server.server)', file=sys.stderr)
7376
print(1)
7477
else:

0 commit comments

Comments
 (0)