Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline outer function #3

Open
bestouff opened this issue May 19, 2019 · 3 comments
Open

Inline outer function #3

bestouff opened this issue May 19, 2019 · 3 comments

Comments

@bestouff
Copy link

The outer function should probably be inlined.

@llogiq llogiq changed the title Online outer function Inline outer function May 24, 2019
@llogiq
Copy link
Owner

llogiq commented May 24, 2019

The current code should do this. However, if the outer function already has an inline annotation, it will get two of them. I should add a check, which is why I'm leaving this open.

@bestouff
Copy link
Author

Good !
Isn't your problem just a case of "if it hurts, don't do it" ?

@llogiq
Copy link
Owner

llogiq commented May 24, 2019

No, because we clone the original function definition's attributes to not interfere with e.g. docs. But if the original function was already inlined, we need to inline the inner function instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants