chore: update according to comments

darcyYe · darcyYe · commit b10179e81309 · 2024-05-24T17:03:00.000+08:00
diff --git a/packages/shared/src/utils/phone.ts b/packages/shared/src/utils/phone.ts
@@ -10,9 +10,13 @@ function validateE164Number(value: string): asserts value is E164Number {
 }
 
 const parseE164Number = (value: string): E164Number | '' => {
-  // If typeof `value` is string and `!value` is true, then `value` is an empty string.
   if (!value) {
-    return '';
+    /**
+     * The type inference engine can not properly infer the type of the empty string,
+     * but using `string` instead. So we need to cast it.
+     */
+    // eslint-disable-next-line no-restricted-syntax
+    return value as '';
   }
 
   const result = value.startsWith('+') ? value : `+${value}`;

Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,13 @@ function validateE164Number(value: string): asserts value is E164Number {`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`const parseE164Number = (value: string): E164Number \| '' => {`
`13`		- // If typeof `value` is string and `!value` is true, then `value` is an empty string.
`14`	`13`	`if (!value) {`
`15`		`- return '';`
	`14`	`+ /**`
	`15`	`+ * The type inference engine can not properly infer the type of the empty string,`
	`16`	+ * but using `string` instead. So we need to cast it.
	`17`	`+ */`
	`18`	`+ // eslint-disable-next-line no-restricted-syntax`
	`19`	`+ return value as '';`
`16`	`20`	`}`
`17`	`21`
`18`	`22`	const result = value.startsWith('+') ? value : `+${value}`;