Skip to content

Commit c03b7a3

Browse files
committed
refactor: rebase master branch
1 parent 1ed8c0a commit c03b7a3

File tree

2 files changed

+20
-11
lines changed

2 files changed

+20
-11
lines changed

packages/core/src/libraries/user.ts

+12-7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint-disable max-lines */
12
import type { BindMfa, CreateUser, MfaVerification, Scope, User } from '@logto/schemas';
23
import { MfaFactor, RoleType, Users, UsersPasswordEncryptionMethod } from '@logto/schemas';
34
import { generateStandardShortId, generateStandardId } from '@logto/shared';
@@ -123,14 +124,19 @@ export const createUserLibrary = (queries: Queries) => {
123124
jsonbMode?: 'replace' | 'merge'
124125
) => {
125126
const validPhoneNumber = conditional(
126-
'primaryPhone' in set &&
127-
typeof set.primaryPhone === 'string' &&
128-
getValidPhoneNumber(set.primaryPhone)
127+
typeof set.primaryPhone === 'string' && getValidPhoneNumber(set.primaryPhone)
129128
);
130129

131130
return updateUserByIdQuery(
132131
id,
133-
{ ...set, ...conditional(validPhoneNumber && { primaryPhone: validPhoneNumber }) },
132+
{
133+
...set,
134+
...conditional(
135+
validPhoneNumber && {
136+
primaryPhone: validPhoneNumber,
137+
}
138+
),
139+
},
134140
jsonbMode
135141
);
136142
};
@@ -148,9 +154,7 @@ export const createUserLibrary = (queries: Queries) => {
148154
assertThat(parameterRoles.length === roleNames.length, 'role.default_role_missing');
149155

150156
const validPhoneNumber = conditional(
151-
'primaryPhone' in data &&
152-
typeof data.primaryPhone === 'string' &&
153-
getValidPhoneNumber(data.primaryPhone)
157+
typeof data.primaryPhone === 'string' && getValidPhoneNumber(data.primaryPhone)
154158
);
155159

156160
return pool.transaction(async (connection) => {
@@ -368,3 +372,4 @@ export const createUserLibrary = (queries: Queries) => {
368372
updateUserById,
369373
};
370374
};
375+
/* eslint-enable max-lines */

packages/core/src/routes/admin-user/mfa-verifications.test.ts

+8-4
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
mockUserTotpMfaVerification,
99
mockUserWithMfaVerifications,
1010
} from '#src/__mocks__/index.js';
11+
import { type InsertUserResult } from '#src/libraries/user.js';
1112
import type Libraries from '#src/tenants/Libraries.js';
1213
import type Queries from '#src/tenants/Queries.js';
1314
import { MockTenant, type Partial2 } from '#src/test-utils/tenant.js';
@@ -44,10 +45,13 @@ const mockLibraries = {
4445
users: {
4546
generateUserId: jest.fn(async () => 'fooId'),
4647
insertUser: jest.fn(
47-
async (user: CreateUser): Promise<User> => ({
48-
...mockUser,
49-
...removeUndefinedKeys(user), // No undefined values will be returned from database
50-
})
48+
async (user: CreateUser): Promise<InsertUserResult> => [
49+
{
50+
...mockUser,
51+
...removeUndefinedKeys(user), // No undefined values will be returned from database
52+
},
53+
{ organizationIds: [] },
54+
]
5155
),
5256
updateUserById: jest.fn(
5357
async (_, data: Partial<CreateUser>): Promise<User> => ({

0 commit comments

Comments
 (0)